Skip to content

fix(deps): update module helm.sh/helm/v3 to v4#225

Merged
cert-manager-prow[bot] merged 2 commits intomasterfrom
renovate/helm.sh-helm-v3-4.x
Mar 28, 2026
Merged

fix(deps): update module helm.sh/helm/v3 to v4#225
cert-manager-prow[bot] merged 2 commits intomasterfrom
renovate/helm.sh-helm-v3-4.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Dec 9, 2025

ℹ️ Note

This PR body was truncated due to platform limits.

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
helm.sh/helm/v3 v3.20.1v4.1.3

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Additional API Compatibility Changes

To support the Helm v3 → v4 upgrade, the following source code changes were made alongside the dependency update:

  • pkg/sign/kmspgp.go: Updated OpenPGP imports from golang.org/x/crypto/openpgp to github.com/ProtonMail/go-crypto/openpgp (including armor and packet sub-packages), as Helm v4 migrated to the ProtonMail fork.

  • pkg/sign/helm.go: Updated to use Helm v4's new ClearSign(archiveData []byte, filename string, metadataBytes []byte) API. In v3, ClearSign accepted a single chart file path and handled I/O internally; in v4, the caller is responsible for reading the archive bytes and providing the chart metadata YAML. The updated code reads the chart archive, loads it via loader.LoadFile to extract the chart metadata, marshals the metadata to YAML, and passes all three arguments to ClearSign.

Release Notes


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

@renovate renovate bot added dependencies Pull requests that update a dependency file ok-to-test labels Dec 9, 2025
@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Dec 9, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 9, 2025
@renovate renovate bot force-pushed the renovate/helm.sh-helm-v3-4.x branch 7 times, most recently from 1e46203 to 4efff3c Compare December 15, 2025 08:30
@renovate renovate bot force-pushed the renovate/helm.sh-helm-v3-4.x branch 2 times, most recently from fb76369 to d7d7b01 Compare December 25, 2025 16:13
@renovate renovate bot force-pushed the renovate/helm.sh-helm-v3-4.x branch 2 times, most recently from fbee73e to 90669de Compare January 15, 2026 00:28
@renovate renovate bot force-pushed the renovate/helm.sh-helm-v3-4.x branch from 90669de to 0b68a18 Compare January 22, 2026 00:25
@renovate renovate bot force-pushed the renovate/helm.sh-helm-v3-4.x branch 5 times, most recently from 6dfb369 to 5f2a51f Compare February 12, 2026 20:45
@renovate renovate bot force-pushed the renovate/helm.sh-helm-v3-4.x branch 5 times, most recently from 1037639 to 6fb9935 Compare February 28, 2026 13:08
@renovate renovate bot force-pushed the renovate/helm.sh-helm-v3-4.x branch 2 times, most recently from ee15a47 to 66e06c9 Compare March 5, 2026 17:17
@renovate renovate bot force-pushed the renovate/helm.sh-helm-v3-4.x branch from 66e06c9 to 0cd256e Compare March 12, 2026 00:36
@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Mar 12, 2026

ℹ️ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 1 additional dependency was updated

Details:

Package Change
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.61.0 -> v0.65.0

@renovate renovate bot force-pushed the renovate/helm.sh-helm-v3-4.x branch from 0cd256e to 00835e9 Compare March 12, 2026 00:42
@renovate renovate bot force-pushed the renovate/helm.sh-helm-v3-4.x branch from 00835e9 to 89460a9 Compare March 19, 2026 12:56
@renovate renovate bot force-pushed the renovate/helm.sh-helm-v3-4.x branch 2 times, most recently from 7f60c5a to 36b644f Compare March 28, 2026 11:49
@erikgb
Copy link
Copy Markdown
Member

erikgb commented Mar 28, 2026

@copilot, can you suggest additional changes to this PR to allow upgrading from Helm v3 to v4?

@cert-manager-prow cert-manager-prow bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Mar 28, 2026
Copy link
Copy Markdown

Copilot AI commented Mar 28, 2026

@copilot, can you suggest additional changes to this PR to allow upgrading from Helm v3 to v4?

In commit 96596c2, I made the following changes to allow upgrading from Helm v3 to v4:

  1. pkg/sign/kmspgp.go: Updated OpenPGP imports from golang.org/x/crypto/openpgp to github.com/ProtonMail/go-crypto/openpgp (and sub-packages), since Helm v4 switched from the former to the latter.

  2. pkg/sign/helm.go: Updated to use Helm v4's new ClearSign(archiveData []byte, filename string, metadataBytes []byte) API. In v3, the caller passed a file path and Helm did all the I/O internally; in v4, the caller must read the archive data and extract the chart metadata itself. The updated code reads the chart archive, loads the chart to extract its metadata (via loader.LoadFile), marshals the metadata to YAML, and passes all three arguments to ClearSign.

@cert-manager-prow cert-manager-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2026
@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Mar 28, 2026

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copilot AI requested a review from erikgb March 28, 2026 12:51
Signed-off-by: Renovate Bot <renovate-bot@users.noreply.github.com>
@erikgb erikgb force-pushed the renovate/helm.sh-helm-v3-4.x branch from 96596c2 to 0ff3026 Compare March 28, 2026 13:29
@erikgb erikgb force-pushed the renovate/helm.sh-helm-v3-4.x branch from 0ff3026 to 44fbee7 Compare March 28, 2026 13:35
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 28, 2026
Copy link
Copy Markdown
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2026
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2026
@cert-manager-prow cert-manager-prow bot merged commit 9ed9286 into master Mar 28, 2026
3 checks passed
@renovate renovate bot deleted the renovate/helm.sh-helm-v3-4.x branch March 28, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. dependencies Pull requests that update a dependency file lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants