Skip to content

fix(hardware::server::hp::oneview::restapi::plugin): add API pagination - CTOR 2151 - #6346

Open
itoussies wants to merge 4 commits into
developfrom
CTOR-2151-plugin-hardware-server-hp-oneview-restapi-mode-hardware-paginated-return-limit-results-and-checks-to-32-servers
Open

fix(hardware::server::hp::oneview::restapi::plugin): add API pagination - CTOR 2151#6346
itoussies wants to merge 4 commits into
developfrom
CTOR-2151-plugin-hardware-server-hp-oneview-restapi-mode-hardware-paginated-return-limit-results-and-checks-to-32-servers

Conversation

@itoussies

@itoussies itoussies commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Centreon team (internal PR)

Description

Fixes: CTOR-2151

The hardware::server::hp::oneview::restapi plugin's hardware mode (server/enclosure components) and storage-pools mode only ever fetched the first page of the HPE OneView REST API's paginated endpoints. A customer with 100+ servers only had the first 32 checked and reported, with no indication anything was missing.

This PR adds request_api_paginated() to custom/api.pm, which follows the API's nextPageUri field until exhausted and merges the members arrays across pages, and switches the three call sites to use it.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
    • Data used for automated tests are anonymized.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences end with a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@itoussies
itoussies marked this pull request as ready for review August 6, 2026 14:37
@itoussies
itoussies requested review from a team as code owners August 6, 2026 14:37
@itoussies
itoussies requested review from Evan-Adam and sechkem and removed request for a team August 6, 2026 14:37
…ew-restapi-mode-hardware-paginated-return-limit-results-and-checks-to-32-servers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant