Client downloads via duckdb-wasm#155
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
katamartin
reviewed
Apr 14, 2026
Member
katamartin
left a comment
katamartin
left a comment
There was a problem hiding this comment.
This is looking + feeling great to me!
Left a few minor suggestions below. But two high-level things to confirm before merging:
- Let's prep a PR to update the screenshot + reference to GeoPackage in the docs site.
- I'm seeing
diffs in CSV contents when I compare the Lambda version to the new version -- are you seeing the same? I think we should make sure we have a good explanation for those.
katamartin
approved these changes
Apr 21, 2026
Member
katamartin
left a comment
katamartin
left a comment
There was a problem hiding this comment.
Left one tracking suggestion, otherwise lgtm!
| controller.signal.aborted || | ||
| (error instanceof DOMException && error.name === 'AbortError') | ||
| if (!isAbort) { | ||
| track('data_download_error', { |
Member
There was a problem hiding this comment.
Maybe we should also track a new data_download_cancel or similar with duration of download when isAbort?
katamartin
reviewed
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This skips our lambda for a direct download via duckdb-wasm (which is lazily downloaded when someone clicks the dl button). It uses the hive-partitioned files on s3.
CSV exactly matches the lamda outputs.
Doing geojson here instead of geopackage because it's a lot easier to create! Also aligns with the stats downloads. (still centroids which avoids memory errors on the biggest counties).
License info is attached to the GeoJSON in a similar way to what we were doing with GeoPackage (adding a little metadata to the top level).
Testing LA county: this finished for me in the browser when lambda seemed to hang, so that seems like an improvement!