Merged
Conversation
Co-authored-by: James Cleveland <james.cleveland@fresha.com>
✅ Deploy Preview for grats ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The build job's "assert no files changed" step checks generated output against what's committed, which is version-specific. The TS matrix belongs only on the test (unit test) job.
- Remove deprecated `downlevelIteration`, add explicit `types: ["node"]` for TS 6's stricter type resolution - Fix catch clauses and implicit any for TS 6 compatibility - Add TS 6.0.2 to CI matrix and pin all TS versions to exact patches - Update changelog Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescriptfromdependenciestopeerDependencies(>=5.5), allowing consumers to use their own TypeScript versiontypescripttodevDependenciesso development continues to workbuildandtestjobs), testing against TS 5.5, 5.7, and ~5.9Based on #187 by @radiosilence. This addresses the concern raised in that PR about validating compatibility across multiple TypeScript versions before making the change.
Test plan
pnpm installworks correctly with the new peerDependency