Skip to content

fix: release action#63

Merged
stefanrudi merged 2 commits intomainfrom
update-release2
Mar 26, 2026
Merged

fix: release action#63
stefanrudi merged 2 commits intomainfrom
update-release2

Conversation

@SirSimon04
Copy link
Copy Markdown
Contributor

Have you...

  • Added relevant entry to the change log?

Copy link
Copy Markdown
Contributor

@hyperspace-insights hyperspace-insights bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is minimal and the full file provides sufficient context. The added line installs @sap/cds-dk@latest globally before npm run build in the publish-npm job. This mirrors what the test job already does (line 23), so the intent is clear. No substantive issues were found.

The pull request makes a small, targeted fix by adding the missing global @sap/cds-dk installation step to the publish-npm job, aligning it with the test job. The change looks correct and no issues were identified.

PR Bot Information

Version: 1.19.3 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • LLM: anthropic--claude-4.6-sonnet
  • Correlation ID: 21a2cdd0-2931-11f1-9256-a61638b56914
  • Event Trigger: pull_request.opened

@SirSimon04 SirSimon04 marked this pull request as ready for review March 26, 2026 17:07
@SirSimon04 SirSimon04 requested a review from a team as a code owner March 26, 2026 17:07
@hyperspace-insights
Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Fix: Release Action Permissions and Build Step

Bug Fix

🐛 Resolved issues in the GitHub Actions release workflow by adding a missing permission and a required build dependency installation step.

Changes

  • .github/workflows/release.yml:
    • Added id-token: write permission to the workflow to support proper token-based authentication during the release process.
    • Added npm i -g @sap/cds-dk@latest step in the publish-npm job to ensure the CDS CLI is available during the build phase, consistent with the test job setup.

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.19.3 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Correlation ID: 450d2c20-2936-11f1-82b4-9c0145b4f4b0
  • Output Template: Default Template
  • Event Trigger: pull_request.ready_for_review
  • Summary Prompt: Default Prompt
  • LLM: anthropic--claude-4.6-sonnet

💌 Have ideas or want to contribute? Create an issue and share your thoughts with us!
📑 Check out the documentation for more information.
📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

Made with ❤️ by Hyperspace.

Copy link
Copy Markdown
Contributor

@hyperspace-insights hyperspace-insights bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff and file look straightforward. Let me check if there are any existing comments on the PR before proceeding.

The two changes are:

  1. id-token: write permission added — required for npm provenance (--provenance flag on npm publish). This is correct.
  2. npm i -g @sap/cds-dk@latest added to the publish-npm job — this mirrors the test job's setup step and is needed so the npm run build step in publish-npm succeeds.

Both changes appear intentional and correct. No substantive issues to flag.

This is a small, focused fix — adding the missing id-token: write permission (required for npm publish --provenance) and the missing @sap/cds-dk global install step in the publish-npm job. The changes are correct and consistent with the existing test job setup. No issues found.

PR Bot Information

Version: 1.19.3 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Correlation ID: 450d2c20-2936-11f1-82b4-9c0145b4f4b0
  • Event Trigger: pull_request.ready_for_review
  • LLM: anthropic--claude-4.6-sonnet

@stefanrudi stefanrudi merged commit 19addb1 into main Mar 26, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants