Skip to content

chore: add log info#59

Merged
two-Gee merged 3 commits intomainfrom
add-log-info
Mar 25, 2026
Merged

chore: add log info#59
two-Gee merged 3 commits intomainfrom
add-log-info

Conversation

@two-Gee
Copy link
Contributor

@two-Gee two-Gee commented Mar 25, 2026

Have you...

  • Added relevant entry to the change log?

@two-Gee two-Gee requested a review from a team as a code owner March 25, 2026 09:26
@hyperspace-insights
Copy link
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Add INFO-Level Logging to Process Service Operations

Chore

🔧 Added LOG.info statements to both BTPProcessService and localProcessService to improve observability for all key process operations.

Changes

  • srv/BTPProcessService.ts: Added LOG.info calls at the start of each operation handler — start, cancel, suspend, resume, getInstancesByBusinessKey, getAttributes, and getOutputs — logging the relevant identifier (e.g., definitionId, businessKey, or processInstanceId).
  • srv/localProcessService.ts: Added matching LOG.info calls for the same set of operations in the local (development) process service, consistent with the BTP implementation.

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.19.3 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • LLM: anthropic--claude-4.6-sonnet
  • Summary Prompt: Default Prompt
  • Event Trigger: pull_request.opened
  • Correlation ID: b85730f0-282c-11f1-85a5-8e2b02f4410a
  • Output Template: Default Template

💌 Have ideas or want to contribute? Create an issue and share your thoughts with us!
📑 Check out the documentation for more information.
📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

Made with ❤️ by Hyperspace.

Copy link
Contributor

@hyperspace-insights hyperspace-insights bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR's structure is sound, but in six places across both files the new LOG.info calls are placed before parameter-guard checks, causing them to emit undefined values into the log on invalid requests. All six instances have been flagged with suggested fixes to move the log statement after the corresponding guard.

PR Bot Information

Version: 1.19.3 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • LLM: anthropic--claude-4.6-sonnet
  • Event Trigger: pull_request.opened
  • Correlation ID: b85730f0-282c-11f1-85a5-8e2b02f4410a

Copy link
Contributor

@tilwbr tilwbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@two-Gee two-Gee merged commit 953581e into main Mar 25, 2026
11 checks passed
@two-Gee two-Gee deleted the add-log-info branch March 25, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants