Conversation
This reverts commit 45d153c.
Member
Author
|
@danjoa I had to revert the PR due to many test failures. Need to investigate the different error patterns, see above. |
This reverts commit a5adcc1.
chgeo
force-pushed
the
revert
branch
5 times, most recently
from
8be35c8 to
d924897
Compare
danjoa
approved these changes
Apr 9, 2026
Contributor
There was a problem hiding this comment.
Reviewed again, added some jsdoc comments and looks good to me. 👍
Member
Author
|
cap/dev is green ✅ Let's merge this beast. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings naxios etc back, reverting commit 45d153c.
Fixes:
validateStatuscan be falsy → fix: validateStatus can be falsy #73arraybufferresponses are not Buffers, fixed with 3a375d1, seecds-graphql/test/tests/queries/variables.test.jsaxios.defaults.maxRedirectsnot supported, fixed with 6d60668, seecds-fiori/test/preview/routes.test.jscontainSubsettoo strict, fixed with d27e127, seecap/dev/test/capire/getting-started.test.jscds-mtxs/test/extensibility/ft-mt-custom-auth/ft-custom-auth.test.js→ remove testAlso support:
axiosis installedchai-as-promisedwith b6d6dbfTests coverage
axios)