feat: malware scan rate limiting & auto retry#411
Open
ansgarlichter wants to merge 12 commits intocap-js:mainfrom
Open
feat: malware scan rate limiting & auto retry#411ansgarlichter wants to merge 12 commits intocap-js:mainfrom
ansgarlichter wants to merge 12 commits intocap-js:mainfrom
Conversation
…ichter/attachments into feat/malware-scanning-auto-retry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The SAP Malware Scanning Service enforces a rate limit of 30 concurrent requests per subaccount. When multiple applications or pods share the same subaccount, bulk uploads can easily trigger 429 responses, causing scan failures and attachments stuck in "Scanning" status.
Additionally, when using remote storage backends (S3, Azure, GCP), each file upload triggered two downloads from the object store: once in put() for inline SHA-256 hash computation, and once in the scanner to send the file to the malware API. Since the scanner response already includes SHA-256, the first download is redundant.
Issues
Closes #401