Skip to content

Remove MTX Sidecar Requirement #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eric-pSAP wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Remove MTX Sidecar Requirement #368

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17886e5
Remove requirement for mtx to be in sidecar
eric-pSAP Feb 4, 2026
ff8eeeb
Update lib/mtx/server.js
eric-pSAP Feb 4, 2026
834043e
Remove semicolons
eric-pSAP Feb 4, 2026
3e23881
Merge branch 'main' into sidecar-requirement-removal
eric-pSAP Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/mtx/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,9 +372,8 @@ const _deleteObjectStoreInstance = async (sm_url, instanceID, token) => {
}

cds.on('listening', async () => {
const profiles = cds.env.profiles ?? [cds.env.profile]
const objectStoreKind = cds.env.requires?.attachments?.objectStore?.kind
if (profiles.includes('mtx-sidecar') && cds.env.requires?.attachments?.kind !== 'db') {
if (cds.env.requires?.multitenancy && cds.env.requires?.attachments?.kind !== 'db') {
const ds = await cds.connect.to("cds.xt.DeploymentService")
if (objectStoreKind === "separate") {
ds.after('subscribe', async (_, req) => {
Expand All @@ -386,11 +385,11 @@ cds.on('listening', async () => {

const token = await _fetchToken(url, clientid, clientsecret, certificate, key)

const existingTenantBindings = await fetchObjectStoreBinding(tenant, token);
const existingTenantBindings = await fetchObjectStoreBinding(tenant, token)

if (existingTenantBindings.length) {
LOG.info(`Existing tenant specific object store for ${tenant} exists. Skipping creation of new one.`)
return;
return
}

const offeringID = await _getOfferingID(sm_url, token)
Expand Down