Repository navigation
docs: correct applyEach callback placement - #2117
Open
Aurantium-47 wants to merge 1 commit into
Open
Aurantium-47 wants to merge 1 commit into
Aurantium-47 wants to merge 1 commit into
Conversation
Assisted-by: OpenAI GPT-6 <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated signatures still show
applyEach(fns, ...args, callback)andapplyEachSeries(fns, ...args, callback), although since v3 the callback belongs to the returned function. TheapplyEachdescription also still describes the old partial-application behavior. Following those signatures returns a function without starting the tasks, as reported in #1658 and #1694.Remove the factory's
callbackparameter from both JSDoc entries, explain the returned function's callback and Promise forms, and add a Promise example. Runtime code is unchanged.Validation:
applyEachtests: 8 passing, including callback, cancellation, native async functions, and Promise usage for both methods.fnsand...args.AI assistance: OpenAI Codex helped prepare and verify this documentation change.