refactor(wallet-sdk): remove default synchronizer auto-selection#1740
Open
jarekr-da wants to merge 9 commits into
Open
refactor(wallet-sdk): remove default synchronizer auto-selection#1740jarekr-da wants to merge 9 commits into
jarekr-da wants to merge 9 commits into
Conversation
jarekr-da
changed the title
jarekr-da
force-pushed
the
jarekr/sdk_synchronizers
branch
from
97545e9 to
3ae7ca0
Compare
jarekr-da
force-pushed
the
wiktor/multisync-example
branch
from
563df2d to
98dfc85
Compare
jarekr-da
force-pushed
the
jarekr/sdk_synchronizers
branch
from
3ae7ca0 to
a84acce
Compare
jarekr-da
force-pushed
the
jarekr/sdk_synchronizers
branch
from
a84acce to
fa21b86
Compare
jarekr-da
changed the title
jarekr-da
force-pushed
the
jarekr/sdk_synchronizers
branch
2 times, most recently
from
7c58d39 to
452af4a
Compare
Contributor
Author
|
Check - where syncId is really needed by canton. |
jarekr-da
force-pushed
the
jarekr/sdk_synchronizers
branch
2 times, most recently
from
0256183 to
51c5d16
Compare
jarekr-da
force-pushed
the
wiktor/multisync-example
branch
from
93653ae to
1bee65e
Compare
…vide synchronizerId Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…examples and snippets Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
… for multi-sync Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…Id to DAR uploads in upload-dars Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…Id to DAR uploads and external party creation The wallet SDK no longer auto-selects a synchronizer. DAR upload and external party creation now require an explicit synchronizerId, which fails on multi-sync participants otherwise. Resolve the global synchronizer via getGlobalSynchronizerId and pass it to dar.upload and party.external.create across the affected example scripts. Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
…arty creation in scripts 08, 09, 12 and stress 01 Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
jarekr-da
force-pushed
the
jarekr/sdk_synchronizers
branch
from
5bf4f06 to
f937203
Compare
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
This
complicatesall existing tests. Code must now explicitly select synchronizer in many calls.Alternative would be to start some tests in single synchronizer (but this also means, such test would fail randomly if run on multi synchronizer localnet).