Skip to content

Fix SV reward weight persistence in Vote History#5874

Open
pawelperek-da wants to merge 8 commits into
mainfrom
pawel/set-sv-weight-fix-prune-friendly
Open

Fix SV reward weight persistence in Vote History#5874
pawelperek-da wants to merge 8 commits into
mainfrom
pawel/set-sv-weight-fix-prune-friendly

Conversation

@pawelperek-da

@pawelperek-da pawelperek-da commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #5092

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@pawelperek-da pawelperek-da force-pushed the pawel/set-sv-weight-fix-prune-friendly branch from fbf17e9 to 16ece6a Compare June 9, 2026 19:57
} yield ResultsPage(recentVoteResults, afterToken)
}

override def lookupLatestSvRewardWeightChange(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limit (cost=1.74..1.75 rows=1 width=1057) (actual time=0.182..0.183 rows=0 loops=1)
--
Buffers: shared hit=55
-> Sort (cost=1.74..1.75 rows=1 width=1057) (actual time=0.181..0.181 rows=0 loops=1)
Sort Key: vote_effective_at DESC
Sort Method: quicksort Memory: 25kB
Buffers: shared hit=55
-> Index Scan using scan_txlog_store_sid_en_vot on scan_txlog_store (cost=0.12..1.73 rows=1 width=1057) (actual time=0.153..0.153 rows=0 loops=1)
Index Cond: (store_id = 1)
Filter: (vote_accepted AND (vote_action_name = 'SRARC_UpdateSvRewardWeight'::text) AND ((entry_data #>> '{result,request,action,value,dsoAction,value,svParty}'::text[]) = 'any-sv::1220abc'::text))
Rows Removed by Filter: 51
Buffers: shared hit=52
Planning:
Buffers: shared hit=282
Planning Time: 5.162 ms
Execution Time: 0.257 ms

@pawelperek-da pawelperek-da force-pushed the pawel/set-sv-weight-fix-prune-friendly branch from 5cf611a to fdcc48d Compare June 11, 2026 12:21
@pawelperek-da pawelperek-da marked this pull request as ready for review June 11, 2026 12:36
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>
@pawelperek-da pawelperek-da force-pushed the pawel/set-sv-weight-fix-prune-friendly branch from fdcc48d to baef416 Compare June 11, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update SV Reward Weight proposal don't persist base weight

1 participant