Traffic-Based App Rewards: Ensure totalAppRewardAmount never exceeds total issuance#5818
Merged
adetokunbo merged 5 commits intoJun 9, 2026
Conversation
adetokunbo
added this to the
Traffic-Based App Rewards M3: On-Ledger Reward Workflow, Dry-Run, and MainNet Deployment milestone
adetokunbo
force-pushed
the
adetokunbo/ensure-total-app-award-cannot-exceed-issuance
branch
2 times, most recently
from
d501966 to
4b4444b
Compare
adetokunbo
force-pushed
the
adetokunbo/ensure-total-app-award-cannot-exceed-issuance
branch
from
4b4444b to
c330480
Compare
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
adetokunbo
force-pushed
the
adetokunbo/ensure-total-app-award-cannot-exceed-issuance
branch
from
c330480 to
ba9f3fd
Compare
meiersi-da
approved these changes
Jun 9, 2026
meiersi-da
left a comment
meiersi-da
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Thank you!
Co-authored-by: Simon Meier <simon@digitalasset.com> Signed-off-by: Timothy Emiola <adetokunbo@users.noreply.github.com>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Also: - change the default value from 0.001 to 0.1 Signed-off-by: Tim Emiola <adetokunbo@emio.la>
adetokunbo
deleted the
adetokunbo/ensure-total-app-award-cannot-exceed-issuance
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4747
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines