Skip to content

Traffic-Based App Rewards: Add minting of RewardCouponV2#5786

Merged
adetokunbo merged 13 commits into
mainfrom
adetokunbo/cip-104-add-minting-of-reward-coupon-v2
Jun 9, 2026
Merged

Traffic-Based App Rewards: Add minting of RewardCouponV2#5786
adetokunbo merged 13 commits into
mainfrom
adetokunbo/cip-104-add-minting-of-reward-coupon-v2

Conversation

@adetokunbo

@adetokunbo adetokunbo commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #5781

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@adetokunbo adetokunbo requested a review from dfordivam June 3, 2026 05:33
@adetokunbo adetokunbo self-assigned this Jun 3, 2026
@adetokunbo adetokunbo marked this pull request as draft June 3, 2026 05:33
dfordivam
dfordivam reviewed Jun 3, 2026
View reviewed changes
Comment thread apps/common/src/main/scala/org/lfdecentralizedtrust/splice/store/TransferInputStore.scala Outdated
@adetokunbo adetokunbo force-pushed the adetokunbo/cip-104-add-minting-of-reward-coupon-v2 branch 2 times, most recently from 5590bed to 1f03eea Compare June 3, 2026 06:24
@adetokunbo adetokunbo marked this pull request as ready for review June 3, 2026 07:17
@adetokunbo adetokunbo requested a review from rautenrieth-da June 3, 2026 07:18
@adetokunbo adetokunbo force-pushed the adetokunbo/cip-104-add-minting-of-reward-coupon-v2 branch from f74c572 to ec07770 Compare June 4, 2026 00:12
@adetokunbo adetokunbo mentioned this pull request Jun 4, 2026
Merged
8 tasks
@adetokunbo adetokunbo force-pushed the adetokunbo/cip-104-add-minting-of-reward-coupon-v2 branch 2 times, most recently from 7db28c1 to c2ae7f8 Compare June 4, 2026 10:06
@adetokunbo adetokunbo requested a review from meiersi-da June 4, 2026 10:19
meiersi-da
meiersi-da approved these changes Jun 4, 2026
View reviewed changes

@meiersi-da meiersi-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good work.

Comment thread ...tralizedtrust/splice/integration/tests/WalletMintingDelegationTimeBasedIntegrationTest.scala Outdated
Comment thread ...rg/lfdecentralizedtrust/splice/integration/tests/WalletRewardsTimeBasedIntegrationTest.scala Outdated
Comment thread ...rg/lfdecentralizedtrust/splice/integration/tests/WalletRewardsTimeBasedIntegrationTest.scala Outdated
Comment thread ...tralizedtrust/splice/integration/tests/WalletMintingDelegationTimeBasedIntegrationTest.scala Outdated
@adetokunbo adetokunbo force-pushed the adetokunbo/cip-104-add-minting-of-reward-coupon-v2 branch 5 times, most recently from b83a783 to 6b6c8c1 Compare June 8, 2026 08:27
adetokunbo added 8 commits June 8, 2026 16:09
@adetokunbo
Add listSortedRewardCouponsV2 to UserWalletStore
393a231 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Update TreasuryService to support rewardCouponV2
06095cf 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
[ci] Assert RewardCouponV2 collection in WalletRewardsTimeBasedIntegr…
9dad955 
…ationTest

Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Add a filter for RewardCouponV2 to ExternalPartyWalletStore
6e791fd 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Support MintingDelegation of RewardCouponV2
284b954 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
[ci] Verify MintingDelegation for RewardCouponV2
3d96766 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Add a TODO highlighting unshared, unassigned RewardCouponV2
c6b3a52 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
s/listSortedRewardCouponsV2/listSortedAssignedRewardCouponV2/
d6160d0 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
adetokunbo and others added 5 commits June 8, 2026 16:09
@adetokunbo
[ci] Include unassigned RewardCouponV2 in the store filters
909dd65 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo @meiersi-da
Use a larger amount to ensure a clearer comparison
aa3f02c 
Co-authored-by: Simon Meier <simon@digitalasset.com>
Signed-off-by: Timothy Emiola <adetokunbo@users.noreply.github.com>
@adetokunbo
Improve and reuse createRewardCouponsV2
26c5b45 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
[ci] Assert minting of RewardCouponV2 along with the faucetCoupon
811ed5a 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
[ci] Use supportsTrafficBasedAppRewards versionGuard
7e46e1a 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo adetokunbo force-pushed the adetokunbo/cip-104-add-minting-of-reward-coupon-v2 branch from 6b6c8c1 to 7e46e1a Compare June 8, 2026 16:10
@adetokunbo adetokunbo mentioned this pull request Jun 9, 2026
Open
@adetokunbo adetokunbo merged commit aec8431 into main Jun 9, 2026
65 checks passed
@adetokunbo adetokunbo deleted the adetokunbo/cip-104-add-minting-of-reward-coupon-v2 branch June 9, 2026 01:08
meiersi-da
meiersi-da reviewed Jun 9, 2026
View reviewed changes
Comment thread apps/common/src/main/scala/org/lfdecentralizedtrust/splice/store/TransferInputStore.scala
rewards
.filter { rw =>
rw.payload.beneficiary.isPresent &&
issuingRoundsMap.contains(rw.payload.round)

@meiersi-da meiersi-da Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
issuingRoundsMap.contains(rw.payload.round)

@adetokunbo : the filter here by round is not necessary, as these coupons can be minted independently of which round is issuing. Can you please create another PR where you remove this filter here, and the related arguments?

@meiersi-da meiersi-da mentioned this pull request Jun 9, 2026
Open
@adetokunbo adetokunbo mentioned this pull request Jun 9, 2026
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfordivam dfordivam dfordivam left review comments

@meiersi-da meiersi-da meiersi-da approved these changes

@rautenrieth-da rautenrieth-da Awaiting requested review from rautenrieth-da

Assignees

@adetokunbo adetokunbo

Labels

None yet

Projects

None yet

Milestone

Traffic-Based App Rewards M3: On-Ledg...

Development

Successfully merging this pull request may close these issues.

Wallet app: Add minting of RewardCouponV2

3 participants

@adetokunbo @dfordivam @meiersi-da