Traffic-Based App Reward: Support bootstrapping with TBA enabled by adetokunbo · Pull Request #5685 · canton-network/splice

adetokunbo · 2026-05-27T04:46:52Z

Fixes #5624

Assumes the following to detect bootstrapping:

the activity meta table is initially empty if bootstrapping
so if there is any existing row, then it's not bootstrapping

Pull Request Checklist

Cluster Testing

If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

Include any change that might be observable by our partners or affect their deployment in the release notes.
Specify fixed issues with Fixes #n, and mention issues worked on using #n
[] Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

dfordivam

See comments, the logic needs to allow the first SV to bump meta userVersion + us to bump codeVersion

dfordivam · 2026-06-02T01:17:50Z

+      // The first SV has complete history from genesis, so round 0 is always
+      // the earliest complete round. The query still runs to confirm ingestion
+      // has started (returns None if no meta row or no activity records).
+      case Some(_) if isFirstSv => Some(0L)


This means the first SV will never be able to update activity meta?
We should check earliest_ingested_round is 0 and only then return 0. Else fallback to the Some value.

I tried that initially, but earliest_ingested_round value as 3 reflecting where the FAP grant was as added, so that check did not work. That's why I've adopted this approach that does not depend on its value. As you have pointed out, as originally implemented this was incorrect, as it blocked bumping the meta versions on firstSV; the latest commit fixes this; PTAL

dfordivam · 2026-06-02T01:20:26Z

+      }
+    }
+
+    "return round 0 on first SV even when ingestion started after genesis" in {


what is the intention behind this?
We have to handle the ingestion "started" after genesis gracefully right?

I've updated the descriptions; PTAL

dfordivam · 2026-06-04T05:16:36Z

              case Some((firstRecordTimeMicros, earliestRound)) =>
+                // First SV on fresh network: earliest complete round is
+                // always 0, so override the given value.
+                val adjustedEarliestRound =


Some how I still feel that actual evidence of bootstrapping, ie round 0 is open, no verdicts ingested, etc is a better way to handle this.
Otherwise the correctness depends upon the state of DB.

Understood; though the upside of depending on that state of the db is that it's unaffected by unexpected errors that might interfere with the other evidence

dfordivam · 2026-06-04T05:22:17Z

+
+  "assertCompleteActivity" should {
+
+    "on first SV" should {


Lets cover scenario where first SV does meta-version bump

dfordivam

Lets get more review from Robert.

dfordivam · 2026-06-04T07:12:19Z

Lets change the assertion here also

dfordivam · 2026-06-04T07:12:39Z

Fix comment

dfordivam · 2026-06-04T07:13:28Z

fix assertion, confirm all contracts for rounds < 11 are gone

Fixed, but only on reverting the environment back 1SV
With the 4SV environment, the contracts did not get archived; an quick investigation was because the non-first-SV scans could not serve root hashes for the early rounds

dfordivam · 2026-06-04T07:25:23Z


  override def environmentDefinition: SpliceEnvironmentDefinition =
    EnvironmentDefinition
      .simpleTopology1SvWithSimTime(this.getClass.getSimpleName)


Lets use simpleTopology4SvsWithSimTime now, as we no longer need the actAs = Seq(dsoParty block

Implemented then reverted this because it caused one of the changed assertions to fail, as explained above.

dfordivam · 2026-06-04T07:27:01Z

Assumes the following to detect bootstrapping:

the activity meta table is initially empty if bootstrapping
so if there is any existing row, then it's not bootstrapping

Another assumption worth mentioning, the networks which are not bootstrapping must already have meta-table row, when this change lands.

dfordivam · 2026-06-04T11:45:07Z


 final case class InitialRewardConfig(
-    mintingVersion: String = "RewardVersion_FeaturedAppMarkers",
+    mintingVersion: String = "RewardVersion_TrafficBasedAppRewards",


I doubt that this is actually doing anything.
Notice initialRewardConfig: Option[InitialRewardConfig] = None,
So lets make sure we test actually turning the rewardConfig ON

…A is enabled Signed-off-by: Tim Emiola <adetokunbo@emio.la>

…on test Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Also: - improve test descriptions Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

…e as a test Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

adetokunbo requested a review from dfordivam May 27, 2026 04:46

adetokunbo self-assigned this May 27, 2026

adetokunbo force-pushed the adetokunbo/cip-104-support-tba-network-bootstrap branch from 24c8172 to 7331734 Compare May 27, 2026 04:47

adetokunbo changed the title ~~Traffic-Based App Reward: Support bootstrapping network when TBA~~ Traffic-Based App Reward: Support bootstrapping wtih TBA enabled May 27, 2026

adetokunbo force-pushed the adetokunbo/cip-104-support-tba-network-bootstrap branch 3 times, most recently from f5477c0 to 2391a94 Compare June 1, 2026 13:46

adetokunbo changed the title ~~Traffic-Based App Reward: Support bootstrapping wtih TBA enabled~~ Traffic-Based App Reward: Support bootstrapping with TBA enabled Jun 1, 2026

adetokunbo force-pushed the adetokunbo/cip-104-support-tba-network-bootstrap branch from 2391a94 to 8134561 Compare June 1, 2026 23:22

dfordivam requested changes Jun 2, 2026

View reviewed changes

adetokunbo requested a review from dfordivam June 3, 2026 01:37

adetokunbo force-pushed the adetokunbo/cip-104-support-tba-network-bootstrap branch from 8134561 to cb47c8e Compare June 3, 2026 01:39

adetokunbo added this to the Traffic-Based App Rewards M3: On-Ledger Reward Workflow, Dry-Run, and MainNet Deployment milestone Jun 3, 2026

dfordivam reviewed Jun 3, 2026

View reviewed changes

Comment thread .../src/main/scala/org/lfdecentralizedtrust/splice/scan/store/db/DbAppActivityRecordStore.scala Outdated

adetokunbo force-pushed the adetokunbo/cip-104-support-tba-network-bootstrap branch 3 times, most recently from 55595d4 to 9f9f141 Compare June 4, 2026 02:22

dfordivam reviewed Jun 4, 2026

View reviewed changes

Comment thread .../src/main/scala/org/lfdecentralizedtrust/splice/scan/store/db/DbAppActivityRecordStore.scala

dfordivam reviewed Jun 4, 2026

View reviewed changes

adetokunbo requested a review from dfordivam June 4, 2026 06:35

dfordivam reviewed Jun 4, 2026

View reviewed changes

adetokunbo force-pushed the adetokunbo/cip-104-support-tba-network-bootstrap branch from 2f724e4 to eb03441 Compare June 4, 2026 09:44

dfordivam reviewed Jun 4, 2026

View reviewed changes

[ci] Traffic-Based App Rewards: Support bootstrapping network when TB…

763ae42

…A is enabled Signed-off-by: Tim Emiola <adetokunbo@emio.la>

adetokunbo added 8 commits June 8, 2026 04:05

[ci] Remove archiving workaround of CalculateRewardsV2 from integrati…

bb3d08a

…on test Signed-off-by: Tim Emiola <adetokunbo@emio.la>

[ci] Make TBA the default in integration tests

ca980ea

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

[ci] Include hasPriorIngestion check

0daf091

Also: - improve test descriptions Signed-off-by: Tim Emiola <adetokunbo@emio.la>

[ci] Reinstate archiveDryRunRewardAccountingContracts test

215769d

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

[ci] Ensure earliest_ingested_round on firstSV/fresh network is 0, us…

e211f57

…e as a test Signed-off-by: Tim Emiola <adetokunbo@emio.la>

[ci] add testcase that cover the meta version being bumped

8c27be5

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Update the integration test environment definition

63d3d3e

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

[ci] Update the integration test assertions

5982308

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

adetokunbo force-pushed the adetokunbo/cip-104-support-tba-network-bootstrap branch from eb03441 to 5982308 Compare June 8, 2026 04:07

Conversation

adetokunbo commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

Cluster Testing

PR Guidelines

Merge Guidelines

Uh oh!

dfordivam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adetokunbo Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adetokunbo Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dfordivam left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adetokunbo Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adetokunbo Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dfordivam commented Jun 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adetokunbo commented May 27, 2026 •

edited

Loading

adetokunbo Jun 3, 2026 •

edited

Loading

adetokunbo Jun 3, 2026 •

edited

Loading

adetokunbo Jun 4, 2026 •

edited

Loading

adetokunbo Jun 4, 2026 •

edited

Loading