Add PPA for dotnet backport during image building#222
Conversation
Agent-Logs-Url: https://github.com/canonical/github-runner-image-builder-operator/sessions/02d4c4d6-96ed-47eb-b259-25a46b167b20 Co-authored-by: yhaliaw <43424755+yhaliaw@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
This PR aims to enable installing additional .NET versions during OpenStack runner image builds by adding the ppa:dotnet/backports repository to the cloud-init provisioning flow. It also includes an unrelated update to the vendored cos_agent charm library affecting scrape config/job naming determinism.
Changes:
- Add
ppa:dotnet/backportsviaadd-apt-repositoryduring image build (cloud-init template + unit test expectation). - Document the change in
docs/changelog.md. - Update vendored
lib/charms/grafana_agent/v0/cos_agent.pyto generate deterministic scrape config job names and deepcopy generic alert rules (LIBPATCH bump).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/charms/grafana_agent/v0/cos_agent.py | Adds deterministic scrape config job naming + deep-copies alert rule templates; bumps library patch. |
| docs/changelog.md | Adds a changelog entry for the dotnet backports PPA change. |
| app/tests/unit/test_openstack_builder.py | Updates expected rendered cloud-init script to include adding the dotnet backports PPA. |
| app/src/github_runner_image_builder/templates/cloud-init.sh.j2 | Adds dotnet backports PPA setup during apt package installation in cloud-init. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Applicable spec:
Overview
Add the PPA for dotnet backports.
Rationale
Needed to install additional dotnet version for different ubuntu base.
E.g., jammy with dotnet 10, resolute with dotnet 8.
Checklist
urgent,trivial,senior-review-required,documentation)app/pyproject.toml