fix: enable NGT-1 send by bumping @canboat/canboatjs to ^3.19.0 - #130
Conversation
canboatjs 3.19.0 adds ActisenseStream.prototype.sendPGN (and threads prio through to encodeActisense). Without it, CanDevice.send crashes with "TypeError: this.stream.sendPGN is not a function" whenever the active connection is an Actisense NGT-1, leaving the Send Raw NMEA 2000 Message tab unusable on those connections.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the ChangesActisense NGT-1 sendPGN fix
🎯 1 (Trivial) | ⏱️ ~2 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #129
Summary by CodeRabbit