Skip to content

fix: enable NGT-1 send by bumping @canboat/canboatjs to ^3.19.0 - #130

Merged
sbender9 merged 1 commit into
canboat:mainfrom
sentientapp:fix/bump-canboatjs-3.19.0
May 29, 2026
Merged

fix: enable NGT-1 send by bumping @canboat/canboatjs to ^3.19.0#130
sbender9 merged 1 commit into
canboat:mainfrom
sentientapp:fix/bump-canboatjs-3.19.0

Conversation

@sentientapp

@sentientapp sentientapp commented May 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #129

Summary by CodeRabbit

  • Chores
    • Updated internal library dependency to a newer version for improved stability and compatibility.

Review Change Stack

canboatjs 3.19.0 adds ActisenseStream.prototype.sendPGN (and threads
prio through to encodeActisense). Without it, CanDevice.send crashes
with "TypeError: this.stream.sendPGN is not a function" whenever the
active connection is an Actisense NGT-1, leaving the Send Raw NMEA
2000 Message tab unusable on those connections.
@coderabbitai

coderabbitai Bot commented May 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9be41229-c3c9-45d0-b056-e735fd0aa1b0

📥 Commits

Reviewing files that changed from the base of the PR and between 04f8b54 and ffc289a.

📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

This PR updates the @canboat/canboatjs dependency from ^3.12.1 to ^3.19.0. The version bump incorporates an upstream fix for Actisense NGT-1 connections where the ActisenseStream class now exposes the sendPGN method, resolving failures when sending raw NMEA 2000 messages.

Changes

Actisense NGT-1 sendPGN fix

Layer / File(s) Summary
Canboat dependency version update
package.json
Dependency on @canboat/canboatjs is bumped from ^3.12.1 to ^3.19.0 to incorporate the upstream ActisenseStream.sendPGN method implementation that resolves the silent transmission failure on Actisense NGT-1 connections.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🐰 A version bump so small, yet fixes so tall,
Actisense NGT-1 now heeds the call,
No code to change, just a manifest line,
The upstream fix makes everything shine! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating @canboat/canboatjs to v3.19.0 to fix NGT-1 send functionality.
Linked Issues check ✅ Passed The PR directly addresses issue #129 by bumping @canboat/canboatjs to v3.19.0, which includes the upstream fix that exposes ActisenseStream.prototype.sendPGN and forwards priority to encodeActisense, resolving the TypeError for NGT-1 connections.
Out of Scope Changes check ✅ Passed The PR contains only a single, scoped change: updating the @canboat/canboatjs dependency version from ^3.12.1 to ^3.19.0, which is directly aligned with the linked issue requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sbender9 sbender9 added the chore label May 29, 2026
@sbender9
sbender9 merged commit 6a1a936 into canboat:main May 29, 2026
2 of 5 checks passed
@sentientapp
sentientapp deleted the fix/bump-canboatjs-3.19.0 branch May 30, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send Raw NMEA 2000 Message tab fails on Actisense NGT-1 connections

2 participants