Add test cases based on real logs#9
Draft
camdroid wants to merge 1 commit into
Draft
Conversation
This diff adds test cases based on real logs found from the alta-open-update lambda. Two interestings things to point out: * We have a case for createMembership, but not createAccount. I wonder if that might cause problems when someone tries to register a new Neon account? * deleteMembership hasn't been called in over a year. Not sure if that's expected (do we ever want to delete someone's account, even if they're no longer an active member?), but just found it interesting. Co-written with Claude AI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff adds test cases based on real logs found from the
alta-open-update lambda.
Two interestings things to point out:
if that might cause problems when someone tries to register a new Neon
account?
expected (do we ever want to delete someone's account, even if they're
no longer an active member?), but just found it interesting.
Co-written with Claude AI.
Stack created with GitHub Stacks CLI • Give Feedback 💬