feat: cli and repo rework #171
Open
+9,220
−616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artus9033
force-pushed
the
feat/cli-and-rework
branch
from
1da0fb5 to
33c29bf
Compare
artus9033
requested review from
hurali97,
okwasniewski and
thymikee
and removed request for
hurali97
okwasniewski
reviewed
Jan 7, 2026
Member
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Nice! Overall looks really good, left few minor comments
Comment on lines
329
to
351
| { | ||
| const artifactName = 'ReactBrownfield.xcframework'; | ||
| artifactNames.push(artifactName); | ||
| await mergeFrameworks({ | ||
| sourceDir: iosBaseDir, | ||
| frameworkPaths: sdks.map((sdk) => | ||
| path.join( | ||
| options.buildFolder ?? | ||
| path.join( | ||
| iosBaseDir, | ||
| 'build', | ||
| `${scheme}-${options.configuration}-${sdk}` | ||
| ), | ||
| 'Build', | ||
| 'Products', | ||
| `${options.configuration}-${sdk}`, | ||
| 'ReactBrownfield', | ||
| 'ReactBrownfield.framework' | ||
| ) | ||
| ), | ||
| outputPath: path.join(outDir, artifactName), | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
We might need to do the same for brownie, a nice future improvement would be to allow to pass in artifact names for the CLI to pick up.
Collaborator
Author
There was a problem hiding this comment.
Do you mean exporting the Brownie native code as a separate XCFramework for native consumption and then packaging it with this CLI?
hurali97
reviewed
Jan 7, 2026
thymikee
reviewed
Jan 7, 2026
| return relativeConfig; | ||
| } | ||
|
|
||
| export async function executeCommand( |
Member
There was a problem hiding this comment.
you can use spawn from Rock tools, it uses nano-spawn under the hood and handles these edge cases
artus9033
force-pushed
the
feat/cli-and-rework
branch
from
d58773e to
d5c11f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
CONTRIBUTING.mddescribing the scripts & anexamples.mdxpage for docs to list and briefly describe each of the example apps in the demo to enhance DX.turbodirectories)The changes address a few important aspects:
Test plan
CI green + all 3 apps working - tested manually.