Skip to content

Fix crash in selectionBox when gltf-model loads after entity is detached #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincentfretin merged 1 commit into from
Apr 25, 2026
Merged

Fix crash in selectionBox when gltf-model loads after entity is detached #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/viewport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,10 @@ export function Viewport(inspector) {
} else if (object.el.hasAttribute('gltf-model')) {
const listener = (event) => {
if (event.target !== object.el) return; // we got an event for a child, ignore
object.el.removeEventListener('model-loaded', listener);
if (object.parent === null) return; // entity was detached before model loaded
selectionBox.setFromObject(object);
selectionBox.visible = true;
object.el.removeEventListener('model-loaded', listener);
};
object.el.addEventListener('model-loaded', listener);
}
Expand Down
Loading