Repository navigation
fix: wasmtime codec - #1516
Merged
Merged
fix: wasmtime codec#1516
Conversation
The owned `wasi:io/input-stream` forwarding loop wrote the end-of-stream marker on `StreamError::Closed` but kept looping, calling `ready()` on the closed stream and writing `0x00` until the writer failed. Return after the marker instead. Assisted-by: claude:claude-fable-5-1
`InputStream::read` returning an empty buffer means no data is ready yet, but the forwarding loop encoded it as a zero-length `list<u8>`, which on the wire is the end-of-stream marker. Skip empty chunks so the receiver only sees the marker once the stream is actually closed. Assisted-by: claude:claude-fable-5-1
Only a present payload was checked against the case type, so `Val::Variant(name, None)` for a payload-carrying case encoded just the discriminant, which the peer cannot decode. Bail on a missing payload too, matching the `result` arm and the wave encoder. Assisted-by: claude:claude-fable-5-1
Record and tuple encoding zipped the value against the type, silently truncating whichever side was longer. Bail on a length mismatch for both. Assisted-by: claude:claude-fable-5-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.