Skip to content

chore: bump wit-bindgen version - #80

Merged
asteurer merged 3 commits into
bytecodealliance:mainfrom
asteurer:bump-wit-bindgen
Oct 7, 2026
Merged

asteurer merged 3 commits into
bytecodealliance:mainfrom
asteurer:bump-wit-bindgen

Conversation

@asteurer

@asteurer asteurer commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

This adds the following changes that were applied upstream to wit-bindgen:

  • Refactors the behavior of the bindings --pkg-name flag
  • Removes the bindings --export-pkg-name flag
  • Bump Go version to 1.27.1
  • Adds a --quiet flag
  • Regenerated example/fixture bindings
  • Applied the breaking API changes in the generated bindings to hand-written example/fixture export files

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
Comment thread src/utils.rs
@dicej

dicej commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Per the CI failures, looks like more updates might be needed for the examples.

@asteurer

asteurer commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor Author

Per the CI failures, looks like more updates might be needed for the examples.

It looks like the addition of the componentize-go.toml file in go.bytecodealliance/pkg@v0.3.0 is causing the failures. When I generate the bindings from scratch and then immediately try to regenerate them, this is what happens:

$ componentize-go --world wasip2-example bindings
WIT PATHS: ["wit"]

$ componentize-go --world wasip2-example bindings       
WIT PATHS: ["/home/asteurer/go/pkg/mod/go.bytecodealliance.org/pkg@v0.3.0/wit"]
Error: no world named `wasip2-example` found in any of the loaded WIT packages

I've tried a few other command permutations, and I'm seeing that the addition of this componentize-go.toml file is going to mess up a lot of default behavior that we've baked into componentize-go. I think it might be best to move the wasiconfig, wasihttp, etc. SDKs to a separate repo. Maybe bytecodealliance/go-wasi accessible via go.bytecodealliance.org/wasi?

@ricochet @jfleitz If y'all have thoughts, I'd be grateful for your input.

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
@asteurer
asteurer marked this pull request as draft October 3, 2026 15:56
@jfleitz

jfleitz commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Per the CI failures, looks like more updates might be needed for the examples.

It looks like the addition of the componentize-go.toml file in go.bytecodealliance/pkg@v0.3.0 is causing the failures. When I generate the bindings from scratch and then immediately try to regenerate them, this is what happens:

$ componentize-go --world wasip2-example bindings
WIT PATHS: ["wit"]

$ componentize-go --world wasip2-example bindings       
WIT PATHS: ["/home/asteurer/go/pkg/mod/go.bytecodealliance.org/pkg@v0.3.0/wit"]
Error: no world named `wasip2-example` found in any of the loaded WIT packages

I've tried a few other command permutations, and I'm seeing that the addition of this componentize-go.toml file is going to mess up a lot of default behavior that we've baked into componentize-go. I think it might be best to move the wasiconfig, wasihttp, etc. SDKs to a separate repo. Maybe bytecodealliance/go-wasi accessible via go.bytecodealliance.org/wasi?

@ricochet @jfleitz If y'all have thoughts, I'd be grateful for your input.

@asteurer apologies, looking at this now. I didn't think that adding the componentize-go.toml to the go-pkg project would have had that impact, and was hoping it would just make it easier to include the standard go-pkg libs.

@asteurer

asteurer commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@jfleitz No worries! It didn't occur to me either when I reviewed it. I'll go ahead and get those moved over to their own repo later today.

@jfleitz

jfleitz commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@jfleitz No worries! It didn't occur to me either when I reviewed it. I'll go ahead and get those moved over to their own repo later today.

Awesome. Let me know if you need me to do the move or not, or if you need anything from me @asteurer !

@asteurer
asteurer marked this pull request as ready for review October 7, 2026 16:18
Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>
@asteurer

asteurer commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@asteurer
asteurer merged commit 79d306d into bytecodealliance:main Oct 7, 2026
5 checks passed
@asteurer
asteurer deleted the bump-wit-bindgen branch October 7, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants