Fix ESM named exports #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Node.js `path` module can be imported with named exports when using ESM. `path-browserify` could not. All exports were rewritten to use `exports.name = value`. This allows to use named imports.
Author
|
Note that this changed indentation of a major part of the file. It’s best reviewed with whitespace changes hidden. |
|
@remcohaszing do you consider forking it and publishing with this change? It seems that when using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node.js
pathmodule can be imported with named exports when using ESM.path-browserifycould not. All exports were rewritten to useexports.name = value. This allows to use named imports. As a bonus this probably also provides better tree shaking.This affects Node.js 12 and upwards. However, CI is configured to run against Node.js up to 10. So I didn’t add tests.