chore: restore v4 generated artifact checks - #2478
Conversation
|
There was a problem hiding this comment.
cubic analysis
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Linked issue analysis
Linked issue: STG-2724: Repair v4-spike generated artifacts and schema strictness
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Replace remaining z.object(...).strict() schemas with z.strictObject(...) in packages/protocol/schemas.ts | The diff shows multiple schema definitions changed from .object(...).strict() to .strictObject(...). |
| ✅ | Regenerate Go protocol models to remove the unreachable __schema8 field from generatedModelCatalog | models.gen.go diff removes the Schema8 field as described in the issue. |
| ✅ | Refresh the embedded Stagehand extension archive to a deterministic build | The extension archive is listed as updated and the PR's reproducibility check shows identical SHA-256 across repeated generation runs. |
| ✅ | TypeScript, Python, and Go generation/build/tests pass (restoring v4-spike CI) | The PR includes E2E test results demonstrating successful TypeScript build/check/tests, Python generation/tests, and Go generation/build/tests after the changes. |
Architecture diagram
sequenceDiagram
participant TS as TypeScript SDK
participant PV as Protocol Schemas
participant GoGen as Go Codegen
participant GoModel as Go Models
participant GoSDK as Go SDK
participant Ext as Stagehand Extension
Note over TS,Ext: PR restores consistency across generated artifacts
TS->>PV: define schemas with z.strictObject()
PV->>GoGen: generate Go models from canonical JSON schema
GoGen->>GoModel: output models.gen.go
GoModel->>GoSDK: compiled into SDK
TS->>Ext: build Stagehand extension archive
Ext->>GoSDK: embedded as stagehand-extension.zip
alt CI validation
TS->>PV: verify generated JSON unchanged
GoSDK->>GoModel: go generate twice yields identical hashes
end
Note over GoModel: unreachable __schema8 field removed
|
Closing as superseded by #2460. That merge incorporated the schema strictness and refreshed the generated Go model and embedded extension; the three previously failing checks now pass directly on |
Summary
z.object(...).strict()protocol schemas with the equivalentz.strictObject(...)formThese files drifted out of sync while the v4 SDK stack landed, causing unrelated pull requests against
v4-spiketo fail the TypeScript, Python build, and Go generation checks.E2E Test Matrix
corepack pnpm build && git diff --exit-code -- packages/protocol/stagehand.v4.json && corepack pnpm check && corepack pnpm exec vitest runuv --directory packages/sdk-python run --locked python scripts/generate.py --checkplus Ruff, ty, and pytestpackages/sdk-python/scripts/smoke.pywith local Chromego generate ./...twiceTracking
STG-2724
Summary by cubic
Restores v4-spike generated artifacts and strict schemas to bring CI back to green. Addresses STG-2724 by syncing TypeScript, Python, and Go SDK outputs and making the embedded Stagehand extension deterministic.
z.object(...).strict()withz.strictObject(...)inpackages/protocol/schemas.ts.__schema8fromgeneratedModelCatalog.packages/sdk-go/internal/extensionassets/stagehand-extension.zipto the deterministic build.Written for commit 3b24135. Summary will update on new commits.