fix local Chrome profile targeting#65
Merged
Merged
Conversation
- Fall back to normal local connect when profile discovery fails - Cache the TUI browser profile label instead of reading settings during render - Validate CDP createTarget params before adding browserContextId - Use a short HTTPS marker URL for profile targeting - Inject the existing Browser Use startup animation after attaching
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
- Marker tab w animation on live website - Require default-profile selection before local browser work - Reuse/focus the selected profile more carefully during reconnects - Avoid extra CDP prompts and duplicate placeholder tabs where possible
There was a problem hiding this comment.
2 issues found across 5 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Tightens local Chrome profile targeting and recovery. Requires a default profile before connecting or running scripts, focuses the right profile for permission prompts, reuses targets/endpoints, and now blocks local connect when profile discovery fails.
Bug Fixes
browser-use-agent: require a default local profile beforebrowser connect localor script start; ifbrowser local profiles --jsonerrors or returnsstatus: "failed", block withstate: "profile-discovery-failed"and do not connect; adddefault_profile_idtobrowser local profiles --jsonwith guidance not to ask the user to pick; onpermission-blocked, return aprofile_recovery_command(browser local open --profile <id> --no-marker) and instruct an immediatebrowser connect localretry; if a connect succeeds in the wrong profile, block withprofile-target-missingand recovery guidance; added tests.browser-use-browser: use a short HTTPS marker URL on the Browser Use site, inject the startup animation after attach, reuse the current placeholder target to avoid extra tabs, prefer endpoint reuse by HTTP base URL even if the WS ID changes, refresh checked-out snapshots to drop stale connections; validate CDPTarget.createTargetparams are an object, only injectbrowserContextIdwhen safe, and reject mismatched contexts; added tests.browser-use-tui: cache the browser profile label in memory and refresh on settings changes; cancelling a live run marks the session cancelled in the store and updates the UI; added tests.Refactors
browser-use-browser: addprofile_marker_target_urland helpers for endpoint health/reuse; remove an unnecessary reattach step before work; expand test coverage.Written for commit 9540337. Summary will update on new commits.