fix: add access control to record_payment (CRITICAL)#375
Open
Kandexa wants to merge 1 commit into
Open
Conversation
CRITICAL: record_payment previously had zero access control — any address could call it to record arbitrary payments on any ephemeral account. Now requires authorized_controller.require_auth() so only the designated sweep controller can record payments. Changes: - Add authorized_controller auth check in record_payment() - Add test verifying unauthorized callers are rejected - Add test verifying authorized controller is accepted Closes bridgelet-org#220
|
@Kandexa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Kandexa resolve conflict please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRITICAL —
record_paymentpreviously had zero access control. Any address could call it to record arbitrary payments on any ephemeral account, enabling payment spoofing attacks.Fix
Added
authorized_controller.require_auth()check inrecord_payment(), restricting the function to only the designated sweep controller.Changes
contracts/ephemeral_account/src/lib.rs: Addcontroller.require_auth()before payment recordingcontracts/ephemeral_account/src/test.rs:test_record_payment_rejects_unauthorized_caller— verifies non-controller calls are rejectedtest_record_payment_accepts_authorized_controller— verifies controller calls succeedTest Results
Closes #220