Create infrastructure.yaml#7
Open
thisrohangupta wants to merge 5 commits intobradrydzewski:masterfrom
Open
Conversation
samples/infrastructure.yaml
Outdated
| tags: {} | ||
| org: default | ||
| project: Platform_Demo | ||
| uses: kubernetes-gke| kubernetes-eks | kubernetes-aks | kubernetes-direct |
Owner
There was a problem hiding this comment.
could these be simplified gke, eks, aks and kubernetes? the thinking is that kubernetes is part of the acronym of these third party offerings so it is not needed as a prefix (e.g. gke is google kubernetes engine)
Contributor
Author
There was a problem hiding this comment.
yes we can do something like that.
samples/infrastructure.yaml
Outdated
| connector: AWSSalesDanF | ||
| region: us-west-2 | ||
| cluster: lg-fargate | ||
| simultaneous-deployment: false |
Owner
There was a problem hiding this comment.
would parallel-deploy: true be the same meaning as simultaneous-deployment: true?
Contributor
Author
There was a problem hiding this comment.
yes parallel deploy would work. Simultaneous deploy means multiple pipelines in parallel can deploy to the same infra def. We won't hold the subsequent pipelines, they will all run and risk overwriting each other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INfra def yaml pr