Replace git:// with https:// in github.com paths#5
Open
johnomotani wants to merge 1 commit intoboutproject:masterfrom
Open
Replace git:// with https:// in github.com paths#5johnomotani wants to merge 1 commit intoboutproject:masterfrom
johnomotani wants to merge 1 commit intoboutproject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
git://protocol does not work for me. Probably because of the company firewall. I had to replace it withhttps://. Maybe this is a useful change? If I understand right, the git protocol is supposed to have better performance, but this repo is small anyway. https may be more robust when accessing through firewalls, so I made this PR. No strong opinion on whether it should go in though - we could just put a note in the README.md instead.