Merged
Conversation
There where files that were broken for at least 15 years. It is better to no tools, then broken tools. Grids can be generated with hypnotoad, for example, which is actively maintained.
dschwoerer
added
discussion
breaking change
Contributor
|
Thanks @dschwoerer ! These tools are not actively maintained or tested. I don't think there is a replacement tool for converting GATO or ELITE files to BOUT++ grids, but these rely on IDL code that is not used often. It's always in the history if needed, I suppose. |
Member
|
Failing test is just clang-tidy-review complaining about not being able to download so many deleted files that it wouldn't even run on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There where files that were broken for at least 15 years.
It is better to no tools, then broken tools.
Grids can be generated with hypnotoad, for example, which
is actively maintained.