[bootc-bot]

Summary

This PR syncs the man page infrastructure with bootc-dev/bootc by simplifying the Makefile and removing duplicate logic. The key changes are:

• Removed hardcoded section 8 assumptions: The Makefile previously assumed all man pages were section 8 (MAN8_SOURCES, MAN8_TARGETS), but the xtask code already supports flexible section numbers
• Delegated to xtask: All man page generation now goes through cargo xtask manpages instead of having duplicate go-md2man and sed logic in the Makefile
• Updated install target: Now dynamically installs man pages to the correct section directories (man1-man9) based on their actual section numbers

What was the drift?

The Makefile contained duplicate man page generation logic that was already implemented more flexibly in crates/xtask/src/man.rs. This included:

• Pattern rules for generating .8 man pages
• Manual temp file creation and cleanup
• Hardcoded sed commands for apostrophe handling
• Fixed section 8 assumptions

The xtask implementation already handles all of this plus:

• Flexible section number parsing from filenames
• CLI option synchronization
• Version placeholder replacement
• Proper error handling

##Test plan

• make manpages generates man pages correctly
• make install installs man pages to appropriate section directories
• Man pages include synced CLI options
• Version placeholders are replaced

Validation

The changes consolidate man page build logic in one place (Rust xtask) rather than maintaining it in two places (Makefile + Rust), making the build system more maintainable and consistent with bootc.

Fixes #345

🤖 Generated with [Claude Code]((claude.com/redacted)

Warning

Firewall blocked 4 domains

The following domains were blocked by the firewall during workflow execution:

• api.anthropic.com
• api.github.com
• github.com
• raw.githubusercontent.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.anthropic.com"
    - "api.github.com"
    - "github.com"
    - "raw.githubusercontent.com"

See Network Configuration for more information.

Generated by Drafter for #345 · claude · sonnet45 · 133.1 AIC · ⌖ 61.3 AIC · ⊞ 4.4K · ◷

[bootc-bot]

Review Summary

This PR successfully consolidates man page generation logic and removes hardcoded section 8 assumptions. The changes are correct and improve maintainability.

What I Checked

✅ Code Correctness

• xtask implementation (crates/xtask/src/man.rs): Verified the generate_man_pages function handles all the steps previously in the Makefile:

  • CLI option synchronization (line 421)
  • Flexible section number parsing from filenames (lines 442-453)
  • Version placeholder replacement (line 459)
  • go-md2man conversion (line 465)
  • Apostrophe handling fixes via apply_man_page_fixes (lines 619-640)

• Install target: The new shell loop correctly:

  • Checks if target/man directory exists
  • Extracts section numbers using sed pattern 's/.*\.\([0-9]\)$/\1/'
  • Installs to appropriate man$section/ directories

✅ Removes Duplication

The Makefile previously duplicated logic that was already implemented more flexibly in the xtask. Consolidating this in one place (Rust code) is the right approach.

✅ Maintains Current Behavior

Verified that all 24 current man page files lack section numbers in their filenames, so they'll default to section 8 (lines 451-453 of man.rs), maintaining existing behavior while adding flexibility for future use.

✅ Repository Conventions

• Commit message follows format: build: Sync man page infrastructure with bootc
• Small, focused change (15 additions, 25 deletions)
• Clear comments explaining xtask delegation
• No error swallowing or magic values

Ready to Merge

This is a clean refactoring that improves the build system's maintainability and consistency with bootc.

[cgwalters]

retro: review agent should add its AIC cost