Conversation
…le styles in the form.
DrJfrost
requested review from
fromagge,
gregjkal and
jlchilders11
and removed request for
fromagge and
gregjkal
gregjkal
left a comment
gregjkal
left a comment
There was a problem hiding this comment.
Looking really good! Few requests.
…, button design adjustments, and the image input for create post is still missing.
julhoang
left a comment
julhoang
left a comment
There was a problem hiding this comment.
We're so close to the finish line!! I just left some questions and suggestions down below but overall this is looking great!
julhoang
left a comment
julhoang
left a comment
There was a problem hiding this comment.
Small UI issue: We're missing a margin for this section on mobile:
|
@herzog0 Hmmm I'm not sure what's going on here, but the checks for your last 2 commits have been running for a long while: |
|
@julhoang all addressed, I think that CI run was some outlier, cause I can't even find it in the logs 🤷 |
|
julhoang
left a comment
julhoang
left a comment
There was a problem hiding this comment.
Fantastic work!! Everything looks great to me 🙌 🎉
| except IntegrityError as e: | ||
| if "slug" in str(e): | ||
| form.add_error( | ||
| "title", | ||
| "A post with this title already exists. Please choose a different title.", | ||
| ) | ||
| else: | ||
| form.add_error( | ||
| None, "An unexpected error occurred. Please try again." | ||
| ) |
There was a problem hiding this comment.
This string-matching (if "slug" in str(e):) seems a lil fragile, though at the same time I'm not sure how else we can robustly check for it since the save() function didn't specifically raise any Exceptions that we can catch 🤷♀️
herzog0
force-pushed
the
form-post-wisiwyg
branch
from
914d6ce to
064e9cb
Compare
6 participants
Issue: #2111
Summary & Context
This pull request introduces a new version of the Create Post component. It also introduces some input component variants, new event triggering mechanisms for dropdowns and adds a small adaptation in the backend, so it supports input validation when knocking on endpoints for this new component.
Changes
news/create_v3.htmltemplate for post creation.core/views.pyandnews/views.pyto conditionally serve V3 templates and populate context data (like dropdown options and initial values) for the modernized post creation flow when thev3flag is active.Although I did my best to try and review what I could, there's much work from the previous iteration of developers that I don't clearly understand, like why we're importing the whole WYSIWYG js file in this branch while
developalready has that file, or why wasn't it updated in a separate branch and then merged to this one.Screenshots
Self-review Checklist
Frontend