Implements lazy buffer rotations#415
Open
mzimbres wants to merge 1 commit intoboostorg:developfrom
Open
Conversation
|
An automated preview of the documentation is available at https://415.redis.prtest3.cppalliance.org/libs/redis/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-05-03 17:50:39 UTC |
Collaborator
|
Thanks. Will have a look soon. |
The read buffer won't rotate data if it can be increased without allocating
more memory. The table below compares the performance before and after the
changes
| time(s) | %usr | %sys | %CPU | rotation
------|---------| ------|------|-------|------------
Eager | 92.22 | 67.37 | 2.92 | 70.29 | 6.7 Gbps
Lazy | 91.16 | 60.15 | 2.82 | 62.97 | 99.0 kbps
The biggest gain in the benchmark above is in CPU usage because the overall
time cannot be decreased much since the client is far from saturating the CPU.
53e42d1 to
83dcec3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read buffer won't rotate data if it can be increased without allocating more memory. The table below compares the performance before and after the changes
The biggest gain in the benchmark above is in CPU usage because the overall time cannot be decreased much since the client is far from saturating the CPU.