Open
Conversation
Draft
Author
|
This PR does not change the public API, but it does change private class members that are not user accessible. Modifying private class members has implications for serialization. Is this type of PR problematic in regards to Boost API stability? |
|
This looks actually quite promising, and performance is better than with our (naiive) solution. Could this be considered for integration? |
Contributor
|
By the way, I think this would help scikit-hep/hist#455. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors regular axis to address the issues described in #336 by incorporating some of the ideas from #386. This PR adds a unit that verifies exact indexing for various cases.
The output of
./benchmark_axis_indexbefore the refactor:The output of
./benchmark_axis_indexafter the refactor: