Repository navigation
Replace BOOST_STATIC_CONSTANT in property.hpp - #641
Conversation
|
Boost dependency footprint vs Header-inclusion weights (graph files pulling each direct dependency in): No header-inclusion-weight changes. Transitive Boost modules: 47 → 47 (0) |
|
Compiler-warning counts vs
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
@varunsha30 thank you very much ! 😄
One tiny remark: in future PRs, would it be possible to avoid mixing reformating (clang-tidy) from refactoring ?
Two reasons besides easier/faster review:
- we will soon update the format and apply one repo-wide PR
- if we are ever to revert merges, it would be nice to revert only what we need (e.g. the reformat) and discard the breaking change (e.g. the constexpr change) 😉
But it's completely fine as is ! Thanks a lot for the extra effort !
Important
New algorithms and API additions need a design issue first. Such a PR is not reviewed until an issue has settled the API and frozen the scope. PRs whose scope grows under review go stale. See How To Contribute an Algorithm.
Motivation
Part of #593
What this PR does
Replace
BOOST_STATIC_CONSTANTininclude/boost/pending/property.hpp.Before submitting
developbranch.Kind of change
Tick exactly one. Each kind is reviewed differently, so mixing them in one PR makes the diff difficult to review (why).
Change category