Skip to content

Replace BOOST_STATIC_CONSTANT in property.hpp - #641

Merged
Becheler merged 1 commit into
boostorg:developfrom
varunsha30:issue-593-3.1-property
Oct 12, 2026
Merged

Becheler merged 1 commit into
boostorg:developfrom
varunsha30:issue-593-3.1-property

Conversation

@varunsha30

Copy link
Copy Markdown
Contributor

Important

New algorithms and API additions need a design issue first. Such a PR is not reviewed until an issue has settled the API and frozen the scope. PRs whose scope grows under review go stale. See How To Contribute an Algorithm.

Motivation

Part of #593

What this PR does

Replace BOOST_STATIC_CONSTANT in include/boost/pending/property.hpp.

Before submitting

  • I searched for an existing PR or issue covering the same change.
  • This PR targets the develop branch.
  • My contribution is licensed under the Boost Software License 1.0.

Kind of change

Tick exactly one. Each kind is reviewed differently, so mixing them in one PR makes the diff difficult to review (why).

  • Reformat (layout only, no token added or removed)
  • Refactor (no observable behavior change)
  • Behavior change (observable to users of the library)
  • No code change (documentation, build, CI, or tooling)

Change category

  • Bug fix
  • New algorithm or API addition
  • Deprecation or removal
  • Performance
  • Tests
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 37969313945 vs develop run 37951267968 (98ec835339).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 47 → 47 (0)

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 37969315207 vs develop run 37951268000 (98ec835339).

Job Baseline After Delta
macos (clang, 14) 253 253 0
macos (clang, 17) 252 252 0
macos (clang, 20) 252 252 0
ubuntu (clang-19, 14) 253 253 0
ubuntu (clang-19, 17) 252 252 0
ubuntu (clang-19, 20) 252 252 0
ubuntu (clang-19, 23) 252 252 0
ubuntu (gcc-14, 14) 349 349 0
ubuntu (gcc-14, 17) 345 345 0
ubuntu (gcc-14, 20) 345 345 0
ubuntu (gcc-14, 23) 345 345 0
windows_msvc_14_3 (msvc-14.3) 937 937 0

@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Becheler Becheler left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varunsha30 thank you very much ! 😄

One tiny remark: in future PRs, would it be possible to avoid mixing reformating (clang-tidy) from refactoring ?

Two reasons besides easier/faster review:

  1. we will soon update the format and apply one repo-wide PR
  2. if we are ever to revert merges, it would be nice to revert only what we need (e.g. the reformat) and discard the breaking change (e.g. the constexpr change) 😉

But it's completely fine as is ! Thanks a lot for the extra effort !

@Becheler
Becheler merged commit 0cbb9ac into boostorg:develop Oct 12, 2026
32 checks passed
@Becheler Becheler added beginner friendly technical debt Code that works but needs refactoring, cleanup, or modernization. Not user-facing. labels Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginner friendly technical debt Code that works but needs refactoring, cleanup, or modernization. Not user-facing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants