Skip to content

Use noexcept loop erased random walk - #624

Merged
Becheler merged 4 commits into
boostorg:developfrom
andreacassioli:use-noexcept-loop_erased_random_walk
Oct 9, 2026
Merged

Becheler merged 4 commits into
boostorg:developfrom
andreacassioli:use-noexcept-loop_erased_random_walk

Conversation

@andreacassioli

@andreacassioli andreacassioli commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Before submitting

  • This PR targets the develop branch.
  • I searched for an existing PR or issue covering the same change.
  • My contribution is licensed under the Boost Software License 1.0.

Type of change

  • Bug fix
  • New feature or API addition
  • Refactor (no behavior change)
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

Does this PR introduce a breaking change?

  • Yes (describe migration impact below)
  • No

What this PR does

Motivation

Testing

Checklist

  • Existing tests pass (b2 in the test/ directory).
  • New behavior is covered by a test, or this is a docs / build / refactor change.
  • Documentation was updated if user-facing behavior changed.
  • No new compiler warnings on the platforms I built against.

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 37801678193 vs develop run 37798542960 (3bab18131b).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 47 → 47 (0)

@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
include/boost/graph/loop_erased_random_walk.hpp 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 37801678168 vs develop run 37798488794 (3bab18131b).

Job Baseline After Delta
macos (clang, 14) 393 393 0
macos (clang, 17) 392 392 0
macos (clang, 20) 392 392 0
ubuntu (clang-19, 14) 393 393 0
ubuntu (clang-19, 17) 392 392 0
ubuntu (clang-19, 20) 392 392 0
ubuntu (clang-19, 23) 392 392 0
ubuntu (gcc-14, 14) 349 349 0
ubuntu (gcc-14, 17) 345 345 0
ubuntu (gcc-14, 20) 345 345 0
ubuntu (gcc-14, 23) 345 345 0
windows_msvc_14_3 (msvc-14.3) 937 937 0

@andreacassioli
andreacassioli marked this pull request as ready for review October 4, 2026 15:25
@Becheler

Becheler commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

#593

@Becheler Becheler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andreacassioli !
One minor thing, the documentation should be modified: https://www.boost.org/doc/libs/develop/libs/graph/doc/html/graph/algorithms/utility/loop_erased_random_walk.html

You can find it here: doc/modules/ROOT/pages/algorithms/utility/loop_erased_random_walk.adoc

@Becheler Becheler added beginner friendly technical debt Code that works but needs refactoring, cleanup, or modernization. Not user-facing. labels Oct 8, 2026
@cppalliance-bot

Copy link
Copy Markdown

An automated preview of the documentation is available at https://624.graph.prtest3.cppalliance.org/libs/graph/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-10-08 15:39:33 UTC

@andreacassioli

Copy link
Copy Markdown
Contributor Author

@Becheler I do not understand the problem with the coverage report. I think the PR is good to merge.

@Becheler

Becheler commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

@andreacassioli aha yes it looks weird! My (little informed) feeling is that you touched lines that were not previously tested and so it complains you should only touch tested lines blabla. I will have a closer look tonight but I will merge it ! Thanks for bumping me up! 🤗

@Becheler
Becheler merged commit 30e14c0 into boostorg:develop Oct 9, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginner friendly technical debt Code that works but needs refactoring, cleanup, or modernization. Not user-facing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants