Fix extra \r added to newlines on windows for old_stream#58
Merged
MHendricks merged 3 commits intomainfrom Mar 13, 2026
Merged
Conversation
MHendricks
force-pushed
the
mikeh/newline_windows_fix
branch
from
8df95aa to
9996848
Compare
The newer `io.TextIOWrapper` implementation was leading to `\r\n` having `\n` replaced with `\r\n` on windows leading to `\r\r\n` newlines. This is not visible in PrEditor's console but in stdout/err.
MHendricks
force-pushed
the
mikeh/newline_windows_fix
branch
from
9996848 to
48eb2c2
Compare
MHendricks
force-pushed
the
mikeh/newline_windows_fix
branch
from
49a9c83 to
4e5e42f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newer
io.TextIOWrapperimplementation was leading to\r\nhaving\nreplaced with\r\non windows leading to\r\r\nnewlines. This is not visible in PrEditor's console but in stdout/err.Checklist
Types of Changes