fix: add --data-dir flag to ethlambda#167
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates lean-quickstart’s Ethlambda client launcher to pass the newly supported --data-dir flag so Ethlambda stores its node data under the expected per-node data directory, and removes an accidentally committed macOS metadata file.
Changes:
- Add
--data-dirto Ethlambda binary invocation ($dataDir/$item) so per-node data is written to the correct location. - Add
--data-dir /datato Ethlambda docker invocation to align with the existing/datavolume mount. - Remove the tracked
.DS_Storefile from the repo.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client-cmds/ethlambda-cmd.sh | Passes --data-dir for both binary and docker execution so Ethlambda writes data to the intended directory. |
| .DS_Store | Removes an accidentally committed macOS Finder metadata file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ch4r10t33r
left a comment
There was a problem hiding this comment.
@MegaRedHand you will need to add the same configuration to ansible/roles/ethlambda/tasks/main.yml. I am working on some improvements, which will remove such duplicate code, but that is likely to be completed a bit later. So for now can you please add the same change in that file as well?
|
@ch4r10t33r Done in 6ffa260 |
We added a
--data-dirflag to ethlambda, but lean-quickstart isn't using it.This PR adds the flag to
ethlambda-cmd.sh, so the node data is stored in the right place. Also removes a.DS_Storefile that was in the repo.