test(tern): pin the one-data-plane-apply-per-deployment invariants - #1065
Draft
aparajon wants to merge 3 commits into
Draft
test(tern): pin the one-data-plane-apply-per-deployment invariants#1065aparajon wants to merge 3 commits into
aparajon wants to merge 3 commits into
Conversation
Sibling shard operations of one deployment dispatched over the real gRPC path carry the same deployment-keyed idempotency key, record the same remote apply id on their operation rows, and never write the parent apply's external_id. The deployment-filtered status endpoint folds those operations into one row that surfaces the shared data-plane apply id while keeping per-operation remote ids out of the fold. The task-store mock now scopes GetByApplyOperationID to the requested operation the way the real store does, so multi-operation dispatch tests exercise true per-operation task sets. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…into armand/deployment-shared-apply-tests
…into armand/deployment-shared-apply-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
The northstar's core invariant — one data-plane apply per deployment, with sibling operations attaching into it — is enforced across four PRs (dispatch keying, attach echo, fail-closed persistence, read model). This capstone pins the whole chain end to end so a regression in any layer fails a test that names the invariant, not a distant symptom.
What it does
external_idstays untouched.GetByApplyOperationIDto the requested operation the way the real store does, so multi-operation dispatch tests exercise genuine per-operation task sets.How it moves us toward the northstar
One data-plane apply per deployment; operations dispatch into it.
Opened by Claude (Fable 5).