feat(acp): inline base prompt override via BUZZ_ACP_BASE_PROMPT - #6421
Closed
tlongwell-block wants to merge 1 commit into
Closed
feat(acp): inline base prompt override via BUZZ_ACP_BASE_PROMPT#6421tlongwell-block wants to merge 1 commit into
tlongwell-block wants to merge 1 commit into
Conversation
The harness could already replace the shipped [Base] platform prompt with --base-prompt-file / BUZZ_ACP_BASE_PROMPT_FILE, or drop it with --no-base-prompt — but there was no inline variant, and none of the three knobs were documented. A file path is unusable in environments where env vars are the only config that travels (remote providers, container launches), while the persona prompt already has the inline+file pair (BUZZ_ACP_SYSTEM_PROMPT / _FILE). Add --base-prompt / BUZZ_ACP_BASE_PROMPT carrying the replacement text inline. It resolves into the existing base_prompt_content channel, so prompt assembly is untouched. Same 1 MB cap as the file path; clap rejects combining it with --no-base-prompt or --base-prompt-file. Document all base/system prompt knobs in a new Prompts section of the crate README, including the replace-not-merge caveat. Co-authored-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz> Signed-off-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
--base-prompt/BUZZ_ACP_BASE_PROMPTto the ACP harness: inline replacement text for the shipped[Base]platform prompt, and documents all base/system prompt knobs in a new Prompts section of the crate README.Why
The harness could already replace the shipped base prompt with
--base-prompt-file/BUZZ_ACP_BASE_PROMPT_FILE, or drop it with--no-base-prompt(#4557) — but there was no inline variant, and none of the three knobs were documented anywhere. A file path is unusable where env vars are the only config that travels (remote providers, container launches). The persona prompt already has the inline+file pair (BUZZ_ACP_SYSTEM_PROMPT/_FILE); this completes the same shape for the base prompt.How
base_prompt_contentchannel, so prompt assembly is untouched — the diff isconfig.rs+ README only (+103 lines, 89 of which are tests and docs).--no-base-promptor--base-prompt-file(verified live for the env-var form too).RESERVED_ENV_KEYS: that list is security-sensitive keys only, and this is the same freely-overridable class asBUZZ_ACP_SYSTEM_PROMPT(per the list's own comment). Desktop users can set it per-agent today.Testing
cargo test -p buzz-acpat head: 806 unit + 9 doc tests passed, 0 failed.cargo clippy/fmtclean; all lefthook pre-push suites green.Opened on behalf of Eva (Buzz agent); original review artifact on the Buzz relay.