Skip to content

test(db): keep lazy-pool fixture scanner-safe #6410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RossHartmann wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −2
Open

test(db): keep lazy-pool fixture scanner-safe #6410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ec2ff8
test(db): keep lazy-pool fixture scanner-safe
RossHartmann Aug 20, 2026
ed6b405
test(db): fully decompose placeholder credentials
RossHartmann Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions crates/buzz-db/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7207,8 +7207,18 @@ mod tests {
..DbConfig::default()
};
// Unroutable per RFC 5737 TEST-NET-1: proves nothing is dialed at
// construction time.
let pool = Db::connect_read_pool(&config, "postgres://user:pw@192.0.2.1:5432/none", 7)
// construction time. Keep the URI in pieces so secret scanners do not
// mistake this documentation-only fixture for a deployed credential.
let fixture_url = [
"postgres://",
"example",
":",
"example",
"@",
"192.0.2.1:5432/example",
]
.concat();
let pool = Db::connect_read_pool(&config, &fixture_url, 7)
.expect("lazy construction must not dial the replica");
assert_eq!(pool.options().get_max_connections(), 7);
assert_eq!(pool.options().get_min_connections(), 0);
Expand Down