test(e2e): bootstrap pages automatically - #6134
Open
loganj wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
nope, sending this back |
loganj
force-pushed
the
fix/e2e-origin-bootstrap
branch
from
August 17, 2026 17:08
2429252 to
f7fe05a
Compare
loganj
changed the title
loganj
force-pushed
the
fix/e2e-origin-bootstrap
branch
3 times, most recently
from
August 19, 2026 01:21
a7ec674 to
e06cd68
Compare
loganj
marked this pull request as ready for review
August 19, 2026 11:28
loganj
force-pushed
the
fix/e2e-origin-bootstrap
branch
19 times, most recently
from
August 21, 2026 00:28
690b438 to
ef77a60
Compare
Preserve unsafe bootstrap events through supported parenthesized forms and grant loop bootstrap credit only when syntax proves an enumerable runtime iteration. Co-authored-by: Larry <larry@buzz.local> Co-authored-by: Brother Darryl <darryl@buzz.local> Signed-off-by: Logan Johnson <loganj@squareup.com>
loganj
force-pushed
the
fix/e2e-origin-bootstrap
branch
from
August 21, 2026 00:36
ef77a60 to
091670f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
Playwright E2E runs can surface
SecurityError: Failed to read the 'localStorage' property from 'Window'when the first app navigation never committed and the browser remains on opaque-originabout:blank. The storage error hides the real problem: a missing E2E build or unavailable preview server.This PR makes app-origin bootstrap explicit and enforced for desktop and web E2E tests. Test setup begins only after navigation to the configured origin, so a failed first navigation reports its expected origin, current URL, and the build/preview-server remedy at the fault.
bootstrapE2ePagehelpers and use explicit bootstrap before page/state access.nullresponse for a same-document/hash navigation, while still rejecting thrown navigation failures, non-OK HTTP responses, and an unexpected final origin.Related issue
None found — this hardens the E2E harness based on the Playwright-on-Blox root-cause probe.