fix(staged): hide ACP session info transcript rows - #927
Merged
Conversation
Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_info_updateACP events were rendered as standalone rows in the session transcript, adding noise (title/updatedAt/_metachurn) that isn't useful to read inline.This removes
session_info_updatefromVISIBLE_STANDALONE_EVENT_KINDSinapps/staged/src/lib/features/sessions/acpTranscript.ts, so those metadata messages are filtered out of the transcript alongside the other operational ACP rows. The events are still written and stored as before — only transcript rendering changes. TheVISIBLE_STANDALONE_EVENT_KINDSset itself is kept (now empty) so future event kinds can opt back in.Testing
acpTranscript.test.tscase asserting thatsession_info_updatemetadata produces no transcript groups, covering both theacpSessionInfoandacpContentpayload shapes.