fix: autodetect color output for pipes#1222
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #971.
--coloras an explicit force-color override.--no-color/NO_COLORas explicit force-off behavior.entandnotif, which previously resetcolor.NoColorafter root command startup.Testing
go test ./cmd/ipsw/cmd -run TestShouldDisableColor -count=1go test ./cmd/ipsw/cmd ./cmd/ipsw/cmd/dyld ./cmd/ipsw/cmd/macho -count=1make build./ipsw macho info --arch arm64e /bin/ls > /tmp/ipsw-macho-info-no-color.txtplus an ANSI escape scan of the redirected file:no_ansiAlso ran
go test ./... -count=1; it reached the broader suite but failed in existing local-fixture/device-dependent areas:pkg/lzmacannot opendata/data.txt, and severalpkg/usb/*tests assume an attached device.AI Assistance
OpenAI GPT-5 helped locate the color-handling paths, draft the patch, and draft this PR text. I reviewed the changed lines and verified the behavior with the commands above.