Inline package-mixins into CodePush.js - #39
Draft
ofalvai wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Inlines package augmentation logic into CodePush.js, simplifying the update API implementation.
Changes:
- Adds package download/install helpers directly to
CodePush.js. - Binds package methods through closures.
- Removes the obsolete mixin module.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
CodePush.js |
Inlines remote and local package behavior. |
package-mixins.js |
Removes the former mixin implementation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| function attachLocalPackageMethods(localPackage) { | ||
| localPackage.install = (installMode, minimumBackgroundDuration, updateInstalledCallback) => | ||
| installUpdate(localPackage, installMode, minimumBackgroundDuration, updateInstalledCallback); | ||
| localPackage.isPending = false; // A local package wouldn't be pending until it was installed |
ofalvai
marked this pull request as draft
August 24, 2026 10:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That mixin pattern is really confusing and serves no real purpose, so let's inline it.
This is still far from ideal, but we can't break certain public APIs.