Skip to content

Portfolio: Enhancement - Misc Improvements#2167

Open
msalcala11 wants to merge 49 commits into
bitpay:developfrom
msalcala11:portfolio-uk
Open

Portfolio: Enhancement - Misc Improvements#2167
msalcala11 wants to merge 49 commits into
bitpay:developfrom
msalcala11:portfolio-uk

Conversation

@msalcala11
Copy link
Copy Markdown
Collaborator

@msalcala11 msalcala11 commented May 13, 2026 •
edited
Loading

  1. Archax updates
  2. Ensures that the top KeyOverview.tsx balance comes from the live BWS cached balance rather than from balance snapshots
  3. Hardens asset decimal resolution
  4. Better handles bad txhistory
  5. Populates portfolio snapshots for wallets of newly imported keys
  6. Displays balance charts on detail screens during mid populate as soon as they're ready
  7. Fixes some balance chart rendering spacing inconsistencies
  8. Prevents double counting of rates storage in the portfolio storage usage item since it is already counted in the rates item
  9. Restores legacy last day PnL and wallet/account/key labels when "Show portfolio" is disabled
  10. Shows fiat value of assets in asset list at all times, including during populate
  11. Ensures that disabling "Show portfolio" also clears the PnL summary cache

And more

@msalcala11 msalcala11 force-pushed the portfolio-uk branch 2 times, most recently from 3c230b4 to f600323 Compare May 16, 2026 17:47
@msalcala11
ref: harden decimal resolution, exclude excessive balance wallets fro…
1eb598f 
…m charts, and retry populating excluded wallets every 24 hrs
msalcala11 added 16 commits May 18, 2026 00:29
@msalcala11
fix: keep showing chart loader until balance chart is renderable
227087b
@msalcala11
ref: only hold wallet details balance chart in loading state for rele…
d4063f0 
…vant reasons
@msalcala11
ref: don't wait for snapshot populate to finish on home root pull to …
fb2743b 
…refresh before hiding loader
@msalcala11
fix: ensure balance chart spans across the full width of the screen o…
31f3b40 
…n all screens
@msalcala11
fix: add right padding to min axis label when it is against the right…
5195b51 
… edge of the screen
@msalcala11
fix: keep rates storage use count only in rates item instead of also …
703d91b 
…in portfolio item
@msalcala11
fix: display legacy pnl and labels in key overview, account details, …
a63bb5f 
…and wallet details when show portfolio is disabled
@msalcala11
ref: show fiat value in asset list items at all times
ba8b3e8
@msalcala11
fix: clear UI PnL summary cache when disabling portfolio
fcd4b4c
@msalcala11
fix: make skeleton loader component dimensions match the components t…
26fcbec 
…hey are foreshadowing
@msalcala11
fix: reduce gap between the Do More and Exchange Rates home sections
ea78b42
@msalcala11
fix: show balance charts for zero-balance wallets with snapshots
6440dd3
@msalcala11
feat: include zero balance wallets with history in asset details wall…
fe0bcb7 
…et list
@msalcala11
fix: make asset details and exchange rate wallet lists identical
e3d16f5
@msalcala11
fix: ensure both include zero balance wallets with snapshots
364520b
@msalcala11
fix: render 0 balance intervals as a flat line
4b05d3d
msalcala11 added 25 commits May 19, 2026 00:21
@msalcala11
fix: fade out max axis label for full 0s charts
c4916c8
@msalcala11
fix: render 0 balance line in middle of chart
433aa37
@msalcala11
fix: fade out min axis label just like max axis label for zero balanc…
5c30b0b 
…e lines
@msalcala11
fix: render wallet details balance section identically for wallets of…
aad9dc4 
… all balances
@msalcala11
ref: color 0 PnL text neutral
9229f43
@msalcala11
ref: remove unneeded prop
79b01b2
@msalcala11
fix: format 0 PnL as 0.00
7b5d492
@msalcala11
ref: simpler
ab79aac
@msalcala11
fix: consistent decimals for crypto balance in wallet item
18da894
@msalcala11
fix: hide balance charts on initial populate
7e9fc82
@msalcala11
fix: use consistent precision in wallet details and account details b…
79d04e8 
…alance between idle balance and scrubbed balance
@msalcala11
fix: display testnet wallet labels
6549355
@msalcala11
ref: display balance charts for wallets without history
4bc62de
@msalcala11
ref: fade out dotted line if timeframe is a flat 0 line
ae8614c
@msalcala11
ref: simplify
bf232ff
@msalcala11
fix: hide balance chart for wallets with non-zero bws balance but no …
c32c2ba 
…snapshots
@msalcala11
fix: gate balance charts while populate data is not ready
5b003e5
@msalcala11
fix: redact wallet IDs from sentry portfolio logs
74b6f3e
@msalcala11
fix: make pull to refresh triggered populates retry quarantined wallets
4efd648
@msalcala11
fix: keep asset rows stable during PnL summary refresh
fd6bbe9
@msalcala11
fix: show collapse/expand home root balance chart button if balance c…
f178185 
…hart is visible
@msalcala11
fix: skip zero balance wallets with no tx history during incremental …
be76600 
…populates
@msalcala11
fix: make excessive_balance_mismatch checks direction agnostic
a9f5e58
@msalcala11
fix: don't await populate when pulling to refresh on any screen
0d5c8a7
@msalcala11
ref: simplify portfolio chart populate changes
ee97a4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@msalcala11