bd-workflows: implement type-based routing within the workflow engine - #577
Open
snowp wants to merge 4 commits into
Open
bd-workflows: implement type-based routing within the workflow engine #577snowp wants to merge 4 commits into
snowp wants to merge 4 commits into
Conversation
Instead of always evaluating all workflows for all logs, this tracks a running set of candidate workflows based on the log type of the log. This allows us to bypass workflows whose next match transitions require a different log type than the inbound log
Contributor
There was a problem hiding this comment.
Pull request overview
Adds log-type-aware workflow routing to avoid evaluating workflows that cannot match an incoming log.
Changes:
- Adds conservative matcher log-type inference.
- Introduces and integrates a workflow candidate router.
- Adds routing and integration tests.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
bd-workflows/src/workflow.rs |
Computes routes from active workflow state. |
bd-workflows/src/test.rs |
Supports typed test logs. |
bd-workflows/src/routing.rs |
Implements candidate routing. |
bd-workflows/src/routing_test.rs |
Tests route selection and refreshes. |
bd-workflows/src/lib.rs |
Registers the routing module. |
bd-workflows/src/engine.rs |
Integrates routing into event processing. |
bd-workflows/src/engine_test.rs |
Tests routing across workflow transitions. |
bd-workflows/src/engine_test_helpers.rs |
Propagates test log types. |
bd-workflows/src/config.rs |
Aggregates configured log types. |
bd-log-matcher/src/matcher.rs |
Adds log-type sets and matcher inference. |
bd-log-matcher/src/matcher_test.rs |
Tests type sets and inference. |
Co-Authored-By: GPT-5 <codex@openai.com>
Co-Authored-By: GPT-5 <codex@openai.com>
Co-Authored-By: GPT-5 <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of always evaluating all workflows for all logs, this tracks a running set of candidate workflows based
on the log type of the log. This allows us to bypass workflows whose next match transitions require a different
log type than the inbound log
Fixes BIT-9477