Add verify-standalone recipe#2031
Open
evanlinjin wants to merge 2 commits intobitcoindevkit:masterfrom
Open
Conversation
This recipe verifies that a crate can be packaged and built in isolation (without workspace dependencies). This is useful for ensuring updated crates do not accidentally depend on breaking changes in upstream crates of the same workspace. Added alias `vs` for quick access to this commonly used verification step. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Verifies all publishable workspace crates can build in isolation. Added alias `vsa` for quick access. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
evanlinjin
force-pushed
the
ci-verify-build-without-workspace
branch
from
54b0033 to
63595ee
Compare
evanlinjin
requested review from
ValuedMammal,
notmandatory and
oleonardolima
evanlinjin
force-pushed
the
ci-verify-build-without-workspace
branch
from
068e47c to
3fbf406
Compare
Collaborator
|
Long term I think it would be great to have a |
Collaborator
|
I'm not sure why, but now bdk_testenv is failing on my machine: |
oleonardolima
approved these changes
Sep 15, 2025
Collaborator
oleonardolima
left a comment
oleonardolima
left a comment
There was a problem hiding this comment.
tACK 3fbf406
It looks fine, the issue I was facing was exclusively on my machine.
notmandatory
approved these changes
Sep 15, 2025
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
tACK 3fbf406
Works for rust stable, doesn't work for MSRV 1.63 or 1.75 but this is expected right?
| @@ -57,3 +59,76 @@ _test-testenv: | |||
|
|
|||
| # Run pre-push suite: format, check, and test | |||
| pre-push: fmt check test | |||
Collaborator
There was a problem hiding this comment.
nit: the new vsa could be added to the pre-push recipe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2030
Description
This recipe verifies that a crate can be packaged and built in isolation (without workspace dependencies).
This is useful for ensuring updated crates do not accidentally depend on breaking changes in upstream crates of the same workspace.
Added alias
vsfor quick access to this commonly used verification step.Checklists
All Submissions: