Improvement of Room Sharing capabilities (followup to #5068 static SIP pins)

[SebastianAppDev]

Dear reviewers,

In my previous pull request (#5068), I added support for static SIP pins. To fully leverage this feature, I've implemented a share button that opens a module allowing users to easily copy the pin, corresponding SIP phone number, and meeting link to their clipboard. Additionally, I've included an option to download an .ics file to easily send the meeting information via email.

To further enhance the user interface, I've made some restructuring changes in this pull request. These changes aim to improve the overall user experience and make the UI more intuitive and user-friendly.

I appreciate your time and feedback on this pull request.

Thank you!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
0.0% Duplication

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[simoncolincap]

We tested this and noticed that the share room link is missing the relative root path. Other than that I hope this can get merged soon, this is a very useful feature.

[SebastianAppDev]

Thanks for the feedback! I've addressed the issue.

[cwillems]

Does this PR obsolete your former one (#5068)?

And do you intent to

• add specs for your changes?
• fix the rubocop check?
• merge upstream once more?

[SebastianAppDev]

Hi,

This PR does not supersede #5068. This PR is only an update to the room sharing functionality, it works well with static PINs as well as without.

I am interested in doing the rest of the work. These two PRs are my first for bigger projects so some guidance on the rubocop checks and specification would be greatly appreciated.

• I can't really tell what the problem is with rubocop (it says waiting for status to be reported??).
• Where are the specs for my changes that are supposed to be documented?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud