Fix remote worker config handoff#2850
Merged
bghira merged 1 commit intoJul 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the remote worker → training subprocess configuration handoff by writing the dispatched training config as JSON and ensuring the training entrypoint loads it via environment variables rather than unsupported CLI flags.
Changes:
- Serialize the orchestrator-dispatched job config to
config.jsonin a job-scoped temp directory. - Launch
python -m simpletuner.trainwithout the unsupported--config/--data_configflags and instead provideCONFIG_PATH+SIMPLETUNER_CONFIG_BACKEND=jsonvia the subprocess environment. - Add an isolated async unit test verifying the config file contents and the subprocess command/env.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
simpletuner/worker_agent.py |
Writes JSON config and switches the training subprocess to load configuration via env vars instead of unsupported CLI args. |
tests/test_worker_agent.py |
Adds regression coverage to ensure the worker writes the correct JSON config and passes the right env to the training subprocess. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONFIG_PATHand the JSON config backend--configand--data_configarguments from the directsimpletuner.traininvocationRoot cause
The remote worker received the complete training config, but wrote it as YAML and passed file arguments that the current training entry point does not consume. The subprocess then fell back to the default
config/config.jsoninstead of loading the dispatched job config.This change only fixes the config handoff. Dataset resolution through
data_backend_configremains unchanged.Verification
checkpoint-1; all 192 saved tensors were finitegit diff --check