Skip to content

remove luminance collection and calculation; it was minimally useful#2845

Merged
bghira merged 1 commit into
mainfrom
refactor/remove-luminance-collection
Jul 17, 2026
Merged

remove luminance collection and calculation; it was minimally useful#2845
bghira merged 1 commit into
mainfrom
refactor/remove-luminance-collection

Conversation

@bghira

@bghira bghira commented Jul 17, 2026

Copy link
Copy Markdown
Owner

This pull request removes all code related to image luminance calculation, storage, and logging throughout the codebase. The luminance feature is no longer used in data processing, metadata, training, validation, or the user interface. This simplifies the code and reduces unnecessary computation and storage.

The most important changes are:

Removal of luminance calculation and usage:

  • Deleted the entire brightness.py module, which contained all functions for calculating image luminance, including batch and multiprocessing support.
  • Removed all calls to and imports of calculate_luminance and related batch luminance methods from image processing, metadata backends, training, and validation code. [1] [2] [3] [4]
  • Eliminated all code that calculated, stored, or updated luminance in batch processing and metadata, including database updates and per-batch calculations. [1] [2] [3] [4] [5]

Removal from data structures and user interface:

  • Removed the luminance field from all batch, metadata, and data model classes, as well as from the dataset viewer UI and API. [1] [2] [3] [4] [5]
  • Removed luminance from logging and reporting in training and validation, including Weights & Biases (wandb) logs and tables. [1] [2] [3] [4] [5] [6]

Test cleanup:

  • Updated or removed test fixtures, mocks, and assertions that referenced luminance values or batch luminance calculation. [1] [2] [3] [4] [5] [6]

@bghira
bghira merged commit 4600196 into main Jul 17, 2026
2 checks passed
@bghira
bghira deleted the refactor/remove-luminance-collection branch July 17, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant