remove luminance collection and calculation; it was minimally useful#2845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes all code related to image luminance calculation, storage, and logging throughout the codebase. The luminance feature is no longer used in data processing, metadata, training, validation, or the user interface. This simplifies the code and reduces unnecessary computation and storage.
The most important changes are:
Removal of luminance calculation and usage:
brightness.pymodule, which contained all functions for calculating image luminance, including batch and multiprocessing support.calculate_luminanceand related batch luminance methods from image processing, metadata backends, training, and validation code. [1] [2] [3] [4]Removal from data structures and user interface:
luminancefield from all batch, metadata, and data model classes, as well as from the dataset viewer UI and API. [1] [2] [3] [4] [5]Test cleanup: